Metrics from Health handlers for Bots V2#844
Merged
canercidam merged 4 commits intomasterfrom Jan 29, 2024
Merged
Conversation
dkeysil
force-pushed
the
kisel/forta-1404-receive-metrics
branch
4 times, most recently
from
62bb77e to
d566444
Compare
dkeysil
requested review from
aomerk and
canercidam
and removed request for
canercidam
Contributor
|
i think it would be useful if we had an e2e test for this one:
|
canercidam
reviewed
Jan 22, 2024
canercidam
reviewed
Jan 22, 2024
canercidam
reviewed
Jan 22, 2024
canercidam
reviewed
Jan 22, 2024
canercidam
reviewed
Jan 26, 2024
Contributor
|
Can we use metric name definitions from the core-go PR? |
…AgentMetrics, supported metrics in the health request Datapoints int64 -> float64 Bump forta-core-go to use int64 for chain id, add chain id to metrics that doesn't have it Add metrics to bothttp/client_test Add check for exceeded response size Remove comment Add chain id from bot config in lifecycle metrics Remove unnecessary metric Pass chain id from alert config, remove todo, fix disco configuration Add TODO Move chain id fallback to metrics aggregator Use forta-core-go metrics names
dkeysil
force-pushed
the
kisel/forta-1404-receive-metrics
branch
from
ce146a4 to
13b0bd7
Compare
dkeysil
force-pushed
the
kisel/forta-1404-receive-metrics
branch
from
838e2a6 to
07de81d
Compare
canercidam
reviewed
Jan 29, 2024
| s.botClient.StartProcessing() | ||
| s.botClient.Initialize() | ||
|
|
||
| <-healthCheckChan |
canercidam
reviewed
Jan 29, 2024
| bucket.MetricDetails[m.Name] = m.Details | ||
|
|
||
| // add chain id if it's not set, e.g. EventMetric | ||
| chainID := ama.chainID |
Contributor
There was a problem hiding this comment.
Thanks for moving this here.
canercidam
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since bots v2 are sending alerts by themselves but no metrics - we need to introduce new way of sending metrics - by polling health handler to gather additional information.
These metrics then are going to be aggregated and indexed.
Changed: