Skip to content

Сhain id from bot config for logs#850

Merged
dkeysil merged 11 commits intomasterfrom
kisel/forta-1563-chain-id-from-bot-config-for-logs
Feb 9, 2024
Merged

Сhain id from bot config for logs#850
dkeysil merged 11 commits intomasterfrom
kisel/forta-1563-chain-id-from-bot-config-for-logs

Conversation

@dkeysil
Copy link
Contributor

@dkeysil dkeysil commented Feb 6, 2024

  • Use since in docker client to get logs only from the past interval time
  • Use tail to limit number of lines (and increase this parameter)
  • Add ChainID from agent config instead of Scanner's ChainID
  • Fix prefix bytes removal from docker logs

@dkeysil dkeysil changed the title Kisel/forta 1563 chain id from bot config for logs Сhain id from bot config for logs Feb 6, 2024
@dkeysil dkeysil force-pushed the kisel/forta-1563-chain-id-from-bot-config-for-logs branch from 20d21cb to 38568b5 Compare February 7, 2024 11:59
@dkeysil dkeysil requested review from aomerk and canercidam February 7, 2024 13:35
@dkeysil dkeysil force-pushed the kisel/forta-1563-chain-id-from-bot-config-for-logs branch from 4206746 to 13fcbdd Compare February 7, 2024 13:37
Copy link
Contributor

@canercidam canercidam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We could improve the mutex usage a little.

@dkeysil dkeysil requested a review from canercidam February 8, 2024 08:44
Co-authored-by: Caner Çıdam <canercidam01@gmail.com>
@dkeysil dkeysil merged commit c3c29f8 into master Feb 9, 2024
@dkeysil dkeysil deleted the kisel/forta-1563-chain-id-from-bot-config-for-logs branch February 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants