Merged
Conversation
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
3 times, most recently
from
092a5d7 to
c28a758
Compare
aomerk
reviewed
Mar 12, 2024
aomerk
reviewed
Mar 12, 2024
aomerk
reviewed
Mar 12, 2024
canercidam
reviewed
Mar 12, 2024
Contributor
canercidam
left a comment
canercidam
left a comment
There was a problem hiding this comment.
It looks great overall! We could polish it a little more.
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
482c8fc to
c82476b
Compare
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
c33cbbd to
2f3b2a9
Compare
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
927c56f to
f83bc1d
Compare
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
f83bc1d to
ed41b8c
Compare
Add cache test Add json rpc cache to executable Make cache config optional, debug logs in cache, fix dispatcher url path Refactor json rpc cache Fix cache keys Use mappers from the forta-core-go Move jsonrpc changes of proxy to cache package Tweak events polling in cache Use go-cache package Rename cbe (Combined Block Event) to BlockData Add retries to r2_client Check 404 error body, check if node has assigned bots Inject sdk cache configuration to agents Refactor Fix registry usage Add logging Update forta-core-go Metrics draft Fix nil panic Fix params string Add log on cache miss Improve polling Increase bucket time if no bots assigned Decrease max backoff to 10 seconds Fix bug in r2 client Retry on 'Block too old' Clean metrics in jsonrpc cache
dkeysil
force-pushed
the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
from
b2a8133 to
2d6c53a
Compare
canercidam
approved these changes
Apr 2, 2024
aomerk
approved these changes
Apr 2, 2024
dkeysil
deleted the
kisel/forta-1609-accept-json-rpc-cache-requests-from-bots
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.