Merged
Conversation
dkeysil
force-pushed
the
kisel/improve-docker-cpu-metric
branch
from
2a7e7ae to
51fbb0b
Compare
dkeysil
force-pushed
the
kisel/improve-docker-cpu-metric
branch
from
51fbb0b to
749ce8f
Compare
dkeysil
force-pushed
the
kisel/improve-docker-cpu-metric
branch
from
749ce8f to
05bcb9a
Compare
canercidam
approved these changes
Apr 11, 2024
aomerk
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is calculation function from the docker library - https://github.com/moby/moby/blob/eb131c5383db8cac633919f82abad86c99bffbe5/cli/command/container/stats_helpers.go#L175-L188
It calculates CPU usage as percentage
Right now this metric (
resources.docker.cpu) is not really helpful becausecpu.TotalUsageis always increasing.