-
Notifications
You must be signed in to change notification settings - Fork 20
Support for neshClassicCache
#73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd like to test this with a snapshot release of sorts @AyronK (sorry, I had intended to raise this as a draft). Do you have a mechanism to publish such releases to NPM? |
@harry-gocity, first please test it locally, the build step is very easy |
|
@harry-gocity any update on testing this? |
3202745 to
f5829ad
Compare
|
Hey @AyronK , sorry I've been so swamped with other priorities I haven't been able to push it that far. I've just rebased onto master (canary looks behind) and I'll look today/tomorrow. |
|
I've built locally, and linked the package to my project. Everything looks ok, working the same that I can see from my current patched version of the neshca package. So I'm happy 😄 I can't test in a real environment with the prerelease though, but of course once this merges and releases, I'll be watching for any issues. We're using PNPM which makes testing locally really easy - |
|
@harry-gocity great! As this does not touch any other files I'll consider it safe to merge ;) I can take a look tomorrow. |
Copies over source from https://github.com/caching-tools/next-shared-cache/blob/%40neshca/cache-handler%401.9.0/packages/cache-handler/src/functions/nesh-classic-cache.ts, with updated imports for
workAsyncStorage. See commit by commit for deviation.#43