Skip to content

Conversation

@harry-gocity
Copy link
Contributor

Copies over source from https://github.com/caching-tools/next-shared-cache/blob/%40neshca/cache-handler%401.9.0/packages/cache-handler/src/functions/nesh-classic-cache.ts, with updated imports for workAsyncStorage. See commit by commit for deviation.

#43

@AyronK AyronK changed the base branch from master to canary August 28, 2025 14:24
@AyronK AyronK self-requested a review August 28, 2025 14:24
@harry-gocity
Copy link
Contributor Author

I'd like to test this with a snapshot release of sorts @AyronK (sorry, I had intended to raise this as a draft). Do you have a mechanism to publish such releases to NPM?

@AyronK
Copy link
Collaborator

AyronK commented Sep 3, 2025

I'd like to test this with a snapshot release of sorts @AyronK (sorry, I had intended to raise this as a draft). Do you have a mechanism to publish such releases to NPM?

@harry-gocity, first please test it locally, the build step is very easy npm i npm run build. Then you can put it in your test project or the minimal test project from the repository. There are many ways to do it, I often just copy the dist files into node_modules as this requires 0 config :)

@AyronK
Copy link
Collaborator

AyronK commented Nov 12, 2025

@harry-gocity any update on testing this?

@harry-gocity harry-gocity changed the base branch from canary to master November 12, 2025 10:59
@harry-gocity
Copy link
Contributor Author

Hey @AyronK , sorry I've been so swamped with other priorities I haven't been able to push it that far. I've just rebased onto master (canary looks behind) and I'll look today/tomorrow.

@harry-gocity
Copy link
Contributor Author

I've built locally, and linked the package to my project. Everything looks ok, working the same that I can see from my current patched version of the neshca package. So I'm happy 😄 I can't test in a real environment with the prerelease though, but of course once this merges and releases, I'll be watching for any issues.

We're using PNPM which makes testing locally really easy - pnpm add /my/path/to/nextjs-cache-handler/packages/nextjs-cache-handler yields

dependencies:
- @fortedigital/nextjs-cache-handler 2.0.3
+ @fortedigital/nextjs-cache-handler 2.2.0 <- ../nextjs-cache-handler/packages/nextjs-cache-handler

@AyronK
Copy link
Collaborator

AyronK commented Nov 12, 2025

@harry-gocity great! As this does not touch any other files I'll consider it safe to merge ;) I can take a look tomorrow.

@AyronK AyronK merged commit 5d86d6b into fortedigital:master Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants