-
Notifications
You must be signed in to change notification settings - Fork 33
Error sourcing fcli_completion #580
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingeffort:mediumMedium effort needed to implement/fixMedium effort needed to implement/fixprio:highHigh priority; important new feature or bug fixHigh priority; important new feature or bug fix
Description
Current Behavior
Running source ./fcli_completion results in the following errors:
-bash: ./fcli_completion: line 6357: syntax error near unexpected token `<'
-bash: ./fcli_completion: line 6357: ` --<action-parameter>)'
Expected Behavior
The fcli_completion script should be sourced without any errors
Steps To Reproduce
- Download any recent fcli version (probably issue exists since fcli 2.4.0)
- Run
source ./fcli_completionafter extracting the download bundle
Environment
No response
Anything else?
This error is caused by the following option declaration in AbstractActionRunCommand; apparently the < and > in the option name cause errors in the completion script:
@Option(names="--<action-parameter>", paramLabel="<value>", descriptionKey="fcli.action.run.action-parameter")
private List<String> dummyForSynopsis;
Easy fix would be to simply remove those characters from the option name, but that makes it less clear for users that this is not a literal option name. Any better approaches?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingeffort:mediumMedium effort needed to implement/fixMedium effort needed to implement/fixprio:highHigh priority; important new feature or bug fixHigh priority; important new feature or bug fix