Skip to content

Comments

Table layout (and update smap)#16

Merged
ldemailly merged 14 commits intomainfrom
conn6
Oct 21, 2025
Merged

Table layout (and update smap)#16
ldemailly merged 14 commits intomainfrom
conn6

Conversation

@ldemailly
Copy link
Member

@ldemailly ldemailly commented Oct 19, 2025

Screenshot 2025-10-21 at 2 28 58 PM
  • add a table layout with left/center/right align options and border options
  • also fix (and break protocol from earlier version) so -name can contain spaces etc by using %q

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.72%. Comparing base (2f47230) to head (17bfd44).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 39 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
+ Coverage   16.53%   33.72%   +17.19%     
===========================================
  Files           8        9        +1     
  Lines         508      673      +165     
===========================================
+ Hits           84      227      +143     
- Misses        416      438       +22     
  Partials        8        8               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldemailly ldemailly changed the title Update smap Table layout (and update smap) Oct 21, 2025
@ldemailly ldemailly marked this pull request as ready for review October 21, 2025 20:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a table layout system for rendering formatted output and updates the protocol format to handle names with spaces. The key changes include:

  • New table package with alignment support (left, center, right)
  • Updated message format in tsnet to use %q for proper escaping of names containing spaces
  • Refactored main.go to use the new table layout instead of string concatenation
  • Updated smap dependency to v1.1.0

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsnet/tsnet.go Changed MessageFormat from %s to %q for proper escaping of names with spaces
table/table.go New package implementing table rendering with alignment options
table/table_test.go Comprehensive test suite for table layout functionality
main.go Refactored to use new table layout system instead of string building
go.mod Updated smap dependency from v1.0.1 to v1.1.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldemailly ldemailly requested a review from Copilot October 21, 2025 20:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldemailly ldemailly requested a review from Copilot October 21, 2025 21:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldemailly ldemailly requested a review from Copilot October 21, 2025 21:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldemailly ldemailly requested a review from Copilot October 21, 2025 22:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldemailly ldemailly requested a review from Copilot October 21, 2025 22:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldemailly ldemailly merged commit 0cef907 into main Oct 21, 2025
9 checks passed
@ldemailly ldemailly deleted the conn6 branch October 21, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants