Skip to content

Conversation

@perazz
Copy link
Member

@perazz perazz commented Nov 30, 2025

The LAPACK library fails to link with an undefined symbol error:

Undefined symbols for architecture ppc:
"___stdlib_string_type_MOD_new_string", referenced from:
___stdlib_io_MOD_get_line_string in stdlib_io.f90.o

When the LAPACK module was modularized in #1033 (commit 80a8164), the stdlib_string_type_constructor.fypp submodule was not included in src/lapack/CMakeLists.txt.

The dependency chain is:

  • stdlib_io.fypp uses string_type() constructor in get_line_string
  • stdlib_string_type.fypp declares the new_string interface
  • stdlib_string_type_constructor.fypp provides the implementation (submodule)

The LAPACK library included the first two but was missing the third, resulting in an undefined symbol at link time.

cc: @barracuda156 @jvdp1

@perazz
Copy link
Member Author

perazz commented Nov 30, 2025

I am not sure this will be a good fix - some of those source files may now appear as duplicates

@barracuda156
Copy link

Provisionally it works, at least it picked up from where it broke and now continuing for a while. I will wait until it finishes, hopefully, and confirm.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.93%. Comparing base (caa060c) to head (29596e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1064   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files         390      390           
  Lines       12650    12650           
  Branches     1377     1377           
=======================================
  Hits         8720     8720           
  Misses       3930     3930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@barracuda156
Copy link

@perazz The build completed successfully. Thank you!

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @perazz

Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @perazz thanks for this fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on Darwin: Undefined symbols for architecture ppc: ___stdlib_string_type_MOD_new_string

4 participants