Skip to content

add zero-diagonal constraint checks for is_skew_symmetric#1169

Merged
jvdp1 merged 1 commit intofortran-lang:masterfrom
srinjoy933:fix-skew-symmetric-fresh
Apr 1, 2026
Merged

add zero-diagonal constraint checks for is_skew_symmetric#1169
jvdp1 merged 1 commit intofortran-lang:masterfrom
srinjoy933:fix-skew-symmetric-fresh

Conversation

@srinjoy933
Copy link
Copy Markdown
Contributor

solve #1168

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.04%. Comparing base (dae9d4b) to head (bd8022e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1169   +/-   ##
=======================================
  Coverage   68.04%   68.04%           
=======================================
  Files         404      404           
  Lines       12948    12948           
  Branches     1395     1395           
=======================================
  Hits         8810     8810           
  Misses       4138     4138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srinjoy933
Copy link
Copy Markdown
Contributor Author

hey @jalvesz @jvdp1 please have a look on this pr and please suggest me if any changes are required

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the is_skew_symmetric test coverage in the linalg test suite by adding explicit validation of the zero-diagonal requirement for skew-symmetric matrices (per issue #1168).

Changes:

  • Adds a new A_false_diag test matrix (per type/kind) that is off-diagonally skew-symmetric but has a non-zero diagonal entry.
  • Extends the test_is_skew_symmetric_* checks to assert is_skew_symmetric(A_false_diag) returns .false. for real, complex (including purely imaginary diagonal), and integer cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @srinjoy933
As it is only adding tests, I will approve and merge this PR.

@jvdp1 jvdp1 merged commit 5c2c391 into fortran-lang:master Apr 1, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants