add zero-diagonal constraint checks for is_skew_symmetric#1169
Merged
jvdp1 merged 1 commit intofortran-lang:masterfrom Apr 1, 2026
Merged
add zero-diagonal constraint checks for is_skew_symmetric#1169jvdp1 merged 1 commit intofortran-lang:masterfrom
jvdp1 merged 1 commit intofortran-lang:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1169 +/- ##
=======================================
Coverage 68.04% 68.04%
=======================================
Files 404 404
Lines 12948 12948
Branches 1395 1395
=======================================
Hits 8810 8810
Misses 4138 4138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the is_skew_symmetric test coverage in the linalg test suite by adding explicit validation of the zero-diagonal requirement for skew-symmetric matrices (per issue #1168).
Changes:
- Adds a new
A_false_diagtest matrix (per type/kind) that is off-diagonally skew-symmetric but has a non-zero diagonal entry. - Extends the
test_is_skew_symmetric_*checks to assertis_skew_symmetric(A_false_diag)returns.false.for real, complex (including purely imaginary diagonal), and integer cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jvdp1
approved these changes
Apr 1, 2026
Member
jvdp1
left a comment
There was a problem hiding this comment.
thank you @srinjoy933
As it is only adding tests, I will approve and merge this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solve #1168