This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Conversation
slucero
suggested changes
Sep 25, 2019
Contributor
slucero
left a comment
slucero
left a comment
There was a problem hiding this comment.
Can we add the basic doc blocks and function descriptions for the add functions?
-
addSshConfigFile() -
addKnownHostsFile()
Contributor
Author
|
Added doc comments and clarified the return value of |
slucero
suggested changes
Sep 25, 2019
| import addWellKnownFile from './addWellKnownFile'; | ||
|
|
||
| /** | ||
| * Returns the `docker run` flags necessary to share the user's SSH configuration file. |
Contributor
There was a problem hiding this comment.
I think the description for these functions was interchanged and should be:
* Returns the `docker run` flags necessary to share the user's known_hosts file.
Contributor
There was a problem hiding this comment.
Suggested change
| * Returns the `docker run` flags necessary to share the user's SSH configuration file. | |
| * Returns the `docker run` flags necessary to share the user's known_hosts file. |
Contributor
Author
|
Whoops. Function comments should be the right way 'round now. |
slucero
approved these changes
Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows containers to see a user's SSH config (when present). The most important effect of this change is that it will allow users to use their jump box settings without having to re-enter them into their Drush aliases.