[156] Update to Next.js 15 and React 19 #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes updates from Next.js codemods.
The render function workaround is no longer supported, so follow the example at https://storybook.js.org/docs/writing-stories/stories-for-multiple-components#reusing-story-definitions
mrclay
reviewed
Mar 18, 2025
| async function NodeFull({ params }: { params: { slug: string[] } }) { | ||
| const { isEnabled } = draftMode(); | ||
| async function NodeFull(props: { params: Promise<{ slug: string[] }> }) { | ||
| const params = await props.params; |
There was a problem hiding this comment.
Next's decision to make an async property getter is super bizarre.
There was a problem hiding this comment.
Yeah, Next 15 definitely includes some choices
mrclay
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156. Also updates Storybook from 8.6.3 to 8.6.6, since that was tangling the React update.