-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor component script #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
📝 WalkthroughWalkthroughThe pull request replaces the Plop-based component scaffolding system with a custom Node.js command-line utility. The new implementation uses Mustache templating and Inquirer prompts to collect component metadata through interactive prompts. Template files are reorganized from the plop-templates directory to a templates directory. The component command in package.json now executes the new create-component.mjs script instead of Plop. Dependencies are updated accordingly, removing Plop and adding Mustache and Inquirer libraries. Template syntax is adjusted to use Handlebars block-style helpers for Mustache compatibility. Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
lib/create-component.mjs(1 hunks)lib/plop-templates/Stylesheet.hbs(0 hunks)lib/templates/Component.hbs(1 hunks)lib/templates/Story.hbs(1 hunks)lib/templates/Stylesheet.hbs(1 hunks)package.json(3 hunks)plopfile.mjs(1 hunks)tsconfig.json(1 hunks)
💤 Files with no reviewable changes (1)
- lib/plop-templates/Stylesheet.hbs
🔇 Additional comments (2)
package.json (2)
16-16: Script command change is appropriate.The script now executes the custom Node CLI script instead of Plop, which aligns with the PR objectives.
37-38: Verify new dependency availability and compatibility.Three new packages are added:
@forumone/tiny-mustache(v1.0.0): An internal ForumOne package—verify it's published and accessible in your package registry.@inquirer/prompts(v7.8.4): Replaces the oldinquirerpackage; confirm this is the correct package for the new prompting implementation.change-case(v5.4.4): Well-established case conversion utility, suitable for component name transformation.All use caret ranges, which is standard for dev dependencies but may introduce minor breaking changes. Confirm that the old
inquirerandploppackages have been fully removed (not visible in the diff).Also applies to: 52-52
# Conflicts: # package-lock.json # package.json
Refactors the component creation script so that we can use the new version of inquirer (now at
@inquirer/prompts). Replacesplopas part of this work and uses an adapted version oftiny-mustacheinstead. Should work pretty much like the old version did.