Skip to content

chore: update display-notification to v3#47

Merged
titanism merged 1 commit intoforwardemail:masterfrom
Progressive-Insurance:update-display-notification
Apr 4, 2026
Merged

chore: update display-notification to v3#47
titanism merged 1 commit intoforwardemail:masterfrom
Progressive-Insurance:update-display-notification

Conversation

@mikejancar
Copy link
Copy Markdown
Contributor

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Changes made

  • Updates the version of display-notification from 2.0.0 to 3.0.0
  • Updates the module's require statement to be dynamic to align with the new version of display-notification

Reason for the change

Some security scanners list the 0.10.0 version of the execa package as being vulnerable to a command injection attack. The execa package is a direct dependency of the run-applescript package which is a direct dependency of display-notification. This update upgrades run-applescript to a ^5.0.0 version which takes execa up to a ^5.0.0 version.

@socket-security
Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/display-notification@3.0.0 🔁 npm/display-notification@2.0.0 Transitive: environment, filesystem, shell +12 131 kB sindresorhus

View full report↗︎

@mikejancar
Copy link
Copy Markdown
Contributor Author

Is there anything else that is needed before this PR can be reviewed? I believe that I have followed all of the guidelines, but I may have missed something.

@jason-easterday
Copy link
Copy Markdown

Looks pretty straight forward to me.

@tcozzens
Copy link
Copy Markdown

tcozzens commented Apr 2, 2025

cc: @titanism @niftylettuce I think this is ready!

@titanism
Copy link
Copy Markdown
Contributor

titanism commented Apr 4, 2026

this is a bit of an anti-pattern to do await again, i'd define let at the top and if its not declared then the await.

ill merge and fix tho, ty

@titanism titanism merged commit 438dc3d into forwardemail:master Apr 4, 2026
titanism added a commit that referenced this pull request Apr 4, 2026
@titanism
Copy link
Copy Markdown
Contributor

titanism commented Apr 4, 2026

v3.1.3 released to npm https://github.com/forwardemail/preview-email/releases/tag/v3.1.3

please consider supporting our efforts and our project, https://forwardemail.net (coupon code GITHUB for 100% off)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants