fix: omit queries that are set to undefined#1486
Merged
niftylettuce merged 1 commit intoforwardemail:masterfrom Jun 6, 2019
Merged
fix: omit queries that are set to undefined#1486niftylettuce merged 1 commit intoforwardemail:masterfrom
niftylettuce merged 1 commit intoforwardemail:masterfrom
Conversation
|
Any updates on this? Currently preventing upgrades to 5.x. /cc @niftylettuce |
Collaborator
|
🎉 v5.0.6 is released to npm, please try it out npm install superagent@latesthttps://github.com/visionmedia/superagent/releases/tag/v5.0.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1481.
It seems we already have a test case for this. However I didn't found how to run it.