chore: format all files with prettier#1902
Closed
Conversation
Member
|
@Fredkiss3 because of the merge conflicts as we get ready for this next release could you redo this PR or adjust it so that we are not formatting all of the files but you just include your changes for the npm run command and other vscode defaults? Then we will format once things are all merged up outside of a PR. |
Contributor
Author
|
@oschwartz10612 noted |
Contributor
Author
|
@oschwartz10612 check #2016 for the VSCode and changes and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Main changes:
Included files are:
.prettierignorefile to see excluded files: https://github.com/Fredkiss3/pangolin/blob/chore/fix-formatting/.prettierignoreOther changes:
npm run format.vscode/settings.jsonwith some default options: setting prettier as the default formatter, and formatting on save.vscode/extensions.jsonwith recommendations for new contributors recommending them to install prettier extension if not installed