Skip to content

Conversation

@ArnavBallinCode
Copy link
Member

@ArnavBallinCode ArnavBallinCode commented Dec 4, 2025

Screenshot 2025-12-04 at 9 41 09 AM

Fixes #1417

Summary by Sourcery

Enhancements:

  • Improve clarity of form question type labels by renaming single-choice to radio button and multi-choice to checkbox with explicit option descriptions.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the user-facing labels for single-choice and multiple-choice question types to use clearer, more descriptive wording about radio buttons and checkboxes.

File-Level Changes

Change Details Files
Retitle the single-choice question type label to explicitly reference radio buttons and single-option selection.
  • Replace the label text for the TYPE_CHOICE question type from 'Choose one from a list' to 'Radio button (Choose one option)'
  • Keep the underlying TYPE_CHOICE constant and behavior unchanged; only the translated display string is updated
app/eventyay/base/models/product.py
Retitle the multiple-choice question type label to explicitly reference checkboxes and multi-option selection.
  • Replace the label text for the TYPE_CHOICE_MULTIPLE question type from 'Choose multiple from a list' to 'Checkbox (Choose one or several options)'
  • Keep the underlying TYPE_CHOICE_MULTIPLE constant and behavior unchanged; only the translated display string is updated
app/eventyay/base/models/product.py

Assessment against linked issues

Issue Objective Addressed Explanation
#1417 Rename the question type labels in both attendee and speaker forms: (a) 'Choose one from a list' → 'Radio button (Choose one option)' and (b) 'Choose multiple from a list' → 'Checkbox (Choose one or several options)'.
#1417 Reinstate drag-and-drop sorting of answer choices for the radio-button and checkbox question types in the speaker form. The PR only updates the display strings for the question type choices in the Question model and does not introduce or modify any drag-and-drop functionality or UI behavior for reordering answer choices.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the labels for form question types to be more descriptive and user-friendly by explicitly mentioning the UI control types (radio button and checkbox) along with clearer descriptions of the selection behavior.

Key Changes:

  • Changed TYPE_CHOICE label from "Choose one from a list" to "Radio button (Choose one option)"
  • Changed TYPE_CHOICE_MULTIPLE label from "Choose multiple from a list" to "Checkbox (Choose one or several options)"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mariobehling mariobehling merged commit 19b75f2 into fossasia:enext Dec 7, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Eventyay Next Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update naming of form question types and improve form input usability in attendee and call for speakers form

2 participants