fix: Use okhttp3 Interceptor in place of Authenticator for network module #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| override fun authenticate(route: Route?, response: Response): Request? { | ||
| override fun intercept(chain: Interceptor.Chain): Response? { | ||
| val authorization: String? = authHolder.getAuthorization() |
Member
There was a problem hiding this comment.
Suggested change
| val authorization: String? = authHolder.getAuthorization() | |
| val authorization = authHolder.getAuthorization() |
| } | ||
|
|
||
| single { RequestAuthenticator(get()) as Authenticator } | ||
| single { RequestAuthenticator(get()) as Interceptor } |
Member
Author
There was a problem hiding this comment.
It is giving same definition error if I do not cast.
| HttpLoggingInterceptor().setLevel(HttpLoggingInterceptor.Level.BODY) | ||
| ) | ||
| .authenticator(get()) | ||
| .build() |
Member
There was a problem hiding this comment.
You have not added the interceptor here. What's the point then?
liveHarshit
force-pushed
the
authenticator
branch
from
0d7a60e to
0e3a04e
Compare
| val authorization = authHolder.getAuthorization() | ||
| val original = chain.request() | ||
| val request = original.newBuilder() | ||
| .header("Authorization", authorization.toString()) |
Member
Author
There was a problem hiding this comment.
It is showing error while running Authorization == null and network module is not working. Because here authorization type is nullable String.
Member
There was a problem hiding this comment.
Only run this if (!Utils.isEmpty), problem solved
liveHarshit
force-pushed
the
authenticator
branch
from
0e3a04e to
fd21da9
Compare
iamareebjamal
approved these changes
Feb 6, 2019
angmas1
pushed a commit
to angmas1/open-event-android
that referenced
this pull request
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006