feat: tweak the search location screen's layout #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the hint which appears in the location text field more polite/professional. Vertically centre the "Use my current location" button text with respect to the button icon. Fixes: fossasia#1056
iamareebjamal
approved these changes
Feb 8, 2019
nikit19
approved these changes
Feb 8, 2019
angmas1
pushed a commit
to angmas1/open-event-android
that referenced
this pull request
Feb 13, 2019
Make the hint which appears in the location text field more polite/professional. Vertically centre the "Use my current location" button text with respect to the button icon. Fixes: fossasia#1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the hint which appears in the location text field more
polite/professional. Vertically centre the "Use my current location"
button text with respect to the button icon.
Fixes #1056
Changes: Make the hint which appears in the location text field more polite/professional and vertically centre the "Use my current location" button text with respect to the button icon.
I've made a separate string resource for the hint instead of modifying the old resource because it was being used in search screen and the new resource was not suitable for use there.
Screenshots for the change:
Before
After