fix: Disable text fields and buttons during progress. #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
suggested changes
Feb 8, 2019
Member
nikit19
left a comment
nikit19
left a comment
There was a problem hiding this comment.
Please make sure that Travis build passes
GOVINDDIXIT
reviewed
Feb 8, 2019
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@nikit19 corrected please review. |
liveHarshit
reviewed
Feb 10, 2019
Member
liveHarshit
left a comment
liveHarshit
left a comment
There was a problem hiding this comment.
Okay, replace progress with dialog progress bar instead.
Member
|
Like that - no need to handle visibality and disable text fields.
|
Contributor
Author
|
Okay |
Contributor
Author
Done! |
liveHarshit
reviewed
Feb 12, 2019
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt
Outdated
Show resolved
Hide resolved
Member
|
The dialog is too large |
Contributor
Author
|
Okay, moving dialog to utils and making it smaller. |
Contributor
Author
|
|
liveHarshit
reviewed
Feb 12, 2019
app/src/main/java/org/fossasia/openevent/general/utils/ProgressDialog.kt
Outdated
Show resolved
Hide resolved
liveHarshit
reviewed
Feb 12, 2019
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt
Outdated
Show resolved
Hide resolved
angmas1
changed the title
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/auth/SignUpFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/auth/SignUpFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/utils/Utils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/utils/Utils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/utils/Utils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/utils/Utils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/utils/Utils.kt
Outdated
Show resolved
Hide resolved
Co-Authored-By: angmas1 <37517284+angmas1@users.noreply.github.com>
Co-Authored-By: angmas1 <37517284+angmas1@users.noreply.github.com>
iamareebjamal
approved these changes
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1045
Changes: When sign-up/login buttons are clicked, the button gets replaced with progress bar and the edit text fields get disabled.
Screenshots for the change:
