Skip to content

Conversation

@angmas1
Copy link
Contributor

@angmas1 angmas1 commented Feb 8, 2019

Fixes #866

Changes: Replaced register button with progress bar when clicked.

Screenshots for the change:
ezgif com-video-to-gif

Copy link
Member

@nikit19 nikit19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really required? Have you seen any app that hides the register button to load the progress bar like this?

@angmas1
Copy link
Contributor Author

angmas1 commented Feb 10, 2019

I think it prevents user from spamming the button and sending multiple requests. We can also disable the button when it's clicked, but I think this looks better and also provides better location for progress bar.

@liveHarshit
Copy link
Member

I think it prevents user from spamming the button and sending multiple requests. We can also disable the button when it's clicked, but I think this looks better and also provides better location for progress bar.

Then disable the button while progress and change its color to something dull.

@angmas1
Copy link
Contributor Author

angmas1 commented Feb 10, 2019

I think it prevents user from spamming the button and sending multiple requests. We can also disable the button when it's clicked, but I think this looks better and also provides better location for progress bar.

Then disable the button while progress and change its color to something dull.
Should I remove the progress bar entirely then?

@liveHarshit
Copy link
Member

liveHarshit commented Feb 11, 2019

@angmas1
Copy link
Contributor Author

angmas1 commented Feb 12, 2019

ezgif com-video-to-gif

Copy link
Member

@liveHarshit liveHarshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angmas1 angmas1 changed the title fix: Replaced register button with progress bar when clicked. fix: Replace register button with progress bar when clicked. Feb 14, 2019
@angmas1
Copy link
Contributor Author

angmas1 commented Feb 20, 2019

@iamareebjamal @nikit19 Please review.

@angmas1
Copy link
Contributor Author

angmas1 commented Feb 22, 2019

@iamareebjamal @nikit19 please review.

@iamareebjamal iamareebjamal merged commit 7028d34 into fossasia:development Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants