-
Notifications
You must be signed in to change notification settings - Fork 555
fix: Replace register button with progress bar when clicked. #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nikit19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really required? Have you seen any app that hides the register button to load the progress bar like this?
|
I think it prevents user from spamming the button and sending multiple requests. We can also disable the button when it's clicked, but I think this looks better and also provides better location for progress bar. |
Then disable the button while progress and change its color to something dull. |
|
liveHarshit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@iamareebjamal @nikit19 Please review. |
|
@iamareebjamal @nikit19 please review. |

Fixes #866
Changes: Replaced register button with progress bar when clicked.
Screenshots for the change:
