refactor: two ViewModels in the welcome screen into one ViewModel #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the welcome screen will be having at least a Fragment and a ViewModel, it makes sense to place them in their own package.
AnEnigmaticBug
changed the title
The fdroid version just hides the "Use my current location" widget.
AnEnigmaticBug
force-pushed
the
iss1073
branch
from
585667f to
8508770
Compare
Member
|
Good work but now we have split two components. 1- Location component and 2- Welcome ViewModel I'm going to merge but this is considered boilerplate |
iamareebjamal
approved these changes
Feb 12, 2019
iamareebjamal
changed the title
Contributor
Author
|
@iamareebjamal I'm trying to rectify this exact issue. Can you please read my new comment on #1082? |
angmas1
pushed a commit
to angmas1/open-event-android
that referenced
this pull request
Feb 13, 2019
…ssasia#1083) Changes: Earlier, there were two `ViewModel`s being used in `WelcomeFragment`. In MVVM, a `View` is associated with only one `ViewModel`. To avoid duplication of logic, all distinct logic is split into smaller classes which can then be reused in different `ViewModel`s. So now, `WelcomeFragment` has only one `ViewModel`(with two flavors: fdroid and playstore). Also, made a separate package for the welcome screen since its also a screen like others. Fixes fossasia#1073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073
Changes: Earlier, there were two
ViewModels being used inWelcomeFragment.In MVVM, a
Viewis associated with only oneViewModel. To avoid duplication of logic, all distinct logic is split into smaller classes which can then be reused in differentViewModels.So now,
WelcomeFragmenthas only oneViewModel(with two flavors: fdroid and playstore). Also, made a separate package for the welcome screen since its also a screen like others.Screenshots for the change:
This is purely a refactoring. So, UI hasn't been changed in any way.