feat: make ImageView aspect ratios same as that of source images #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ImageViews in item_card_events.xml, item_card_similar_events.xml and content_event.xml that display event images have width/height ratio of 2:1 which is the same as that of the images they display. Earlier, since the ratios of ImageViews and images were different, the images were clipped. This was clearly noticeable on some images. This change involved converting those layouts to ConstraintLayout because ConstraintLayout allows setting ratios. Fixes: fossasia#1135
AnEnigmaticBug
force-pushed
the
iss1135
branch
from
9f83f6d to
d2c53f1
Compare
iamareebjamal
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1135
Changes: The
ImageViews initem_card_events.xml,item_card_similar_events.xmlandcontent_event.xmlthat display event images have width/height ratio of 2:1 which is the same as that of the images they display.Earlier, since the ratios of
ImageViews and images were different, the images were clipped. This was clearly noticeable on some images.This change involved converting those layouts to
ConstraintLayoutbecauseConstraintLayoutallows setting ratios.Screenshots for the change: