fix: Improve UI of Login and SignUp Activity #554
Conversation
|
This is my first PR here. Can anyone guide how things goes here. |
simarsingh24
left a comment
simarsingh24
left a comment
There was a problem hiding this comment.
We are following eventbrite app can you confirm this UI is similar to Eventbrite's? Also the email logo and email text is too close. Please also follow commit guidelines!
app/src/main/res/values/strings.xml
Outdated
|
|
||
| <!--eventyay--> | ||
| <string name="eventyay_logo">eventyay</string> | ||
| <string name="eventyay_logo">Eventyay</string> |
There was a problem hiding this comment.
Ok, I will update these changes
There was a problem hiding this comment.
@GOVINDDIXIT Please use vector icons too
app/src/main/res/values/colors.xml
Outdated
| <color name="black">#000000</color> | ||
| <color name="grey">#ece9e9</color> | ||
| <color name="greyMore">#918e8e</color> | ||
| <color name="white">#ffffff</color> |
There was a problem hiding this comment.
No need of adding white color. Just use @android:color/white
|
@dreadpool2 review please |
|
@nikit19 review please |
nikit19
left a comment
nikit19
left a comment
There was a problem hiding this comment.
Looks good. Just this minor change and we are good to go.
Also could you update the screenshot after making the changes
| android:text="@string/sign_up" /> | ||
| android:text="@string/sign_up" | ||
| android:textColor="@android:color/white" | ||
| android:background="@color/colorPrimary"/> |
|
@nikit19 review pls |
GOVINDDIXIT
changed the title
5 participants
Fixes #553
Screenshots for the change:
Before:-
After:-
