Skip to content

fix: Load user details in Edit Profile section #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2018
Merged

fix: Load user details in Edit Profile section #574

merged 1 commit into from
Sep 23, 2018

Conversation

@liveHarshit
Copy link
Member

@liveHarshit liveHarshit commented Sep 22, 2018 •
edited
Loading

Fixes #568

@liveHarshit
Copy link
Member Author

liveHarshit commented Sep 22, 2018

Here I want to place hideSoftKeyboard method at a commonplace so that it can call directly whenever requires. Please suggest me where I can place it.

@fossasia fossasia deleted a comment Sep 22, 2018
@fossasia fossasia deleted a comment Sep 22, 2018
@liveHarshit
Copy link
Member Author

liveHarshit commented Sep 22, 2018

Updated

iamareebjamal
iamareebjamal reviewed Sep 22, 2018
View reviewed changes
app/src/main/java/org/fossasia/openevent/general/auth/LoginFragment.kt Outdated
rootView.loginButton.setOnClickListener {
loginActivityViewModel.login(email.text.toString(), password.text.toString())
hideSoftKeyboard()
hideSoftKeyboard(rootView.context, rootView)
Copy link
Member

@iamareebjamal iamareebjamal Sep 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't pass view's context here

iamareebjamal
iamareebjamal reviewed Sep 22, 2018
View reviewed changes
app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt Outdated
}

rootView.buttonUpdate.setOnClickListener {
hideSoftKeyboard(rootView.context, rootView)
Copy link
Member

@iamareebjamal iamareebjamal Sep 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@iamareebjamal
Copy link
Member

iamareebjamal commented Sep 22, 2018

Yes, please revert all unrelated changes from the PR. You can send a new PR to handle warnings

@liveHarshit
Copy link
Member Author

liveHarshit commented Sep 22, 2018

Yes, please revert all unrelated changes from the PR. You can send a new PR to handle warnings

Okay got it. By next time I will change in code related to the issue only. For extra changes or warning, need to submit new PR related to new issue. 👍

@liveHarshit
Copy link
Member Author

liveHarshit commented Sep 22, 2018

updated

@fossasia fossasia deleted a comment Sep 22, 2018
@fossasia fossasia deleted a comment Sep 22, 2018
@liveHarshit
Copy link
Member Author

liveHarshit commented Sep 23, 2018

Updated

@fossasia fossasia deleted a comment Sep 23, 2018
@fossasia fossasia deleted a comment Sep 23, 2018
@fossasia fossasia deleted a comment Sep 23, 2018
@fossasia fossasia deleted a comment Sep 23, 2018
@fossasia fossasia deleted a comment Sep 23, 2018
@iamareebjamal iamareebjamal merged commit 504cf53 into fossasia:development Sep 23, 2018
@liveHarshit liveHarshit deleted the issue568 branch September 25, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+1 more reviewer

@nikit19 nikit19 nikit19 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liveHarshit @iamareebjamal @nikit19