fix: App stuck when open event from favorites #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
changed the title
| } else { | ||
| loadFragment(EventsFragment()) | ||
| navigation.selectedItemId = navigation_events | ||
| } |
Member
There was a problem hiding this comment.
This is getting too complicated. Think of a different solution
Member
Author
There was a problem hiding this comment.
This is getting too complicated. Think of a different solution
Updated. please review.
Member
Author
Member
Author
|
@iamareebjamal Please review it. |
iamareebjamal
approved these changes
Oct 28, 2018
| val currentFragment = this.supportFragmentManager.findFragmentById(R.id.frameContainer) | ||
| if (currentFragment !is EventsFragment) { | ||
| val rootFragment = this.supportFragmentManager.findFragmentById(R.id.rootLayout) | ||
| if (currentFragment !is EventsFragment && rootFragment !is EventDetailsFragment) { |
Member
There was a problem hiding this comment.
This is also special casing but OK, it was already there
nikit19
approved these changes
Nov 1, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631
Changes: MainActivity.kt