fix: User avatar not loading in EditProfileFragment #654
Conversation
codepoet2017390
left a comment
codepoet2017390
left a comment
There was a problem hiding this comment.
I think you should not change any gradle file. Also it would be better if you remove the extra spaces
|
Please follow PR guidelines |
Hello! This is my first PR on any FOSS project. I'd really appreciate some guidance on what I'm doing wrong. Please let me know the PR guidelines. |
| rootView.lastName.setText(userLastName) | ||
| Picasso.get() | ||
| .load(imageUrl) | ||
| .placeholder(AppCompatResources.getDrawable(context!!, R.drawable.ic_account_circle_grey_24dp)!!) |
There was a problem hiding this comment.
Can you remove the exclamation marks and click on the red bulb that appears.
You can then select the option to wrap it with ?. let call .
There was a problem hiding this comment.
Yes, I'm adding null checks to it right now. Thank you!
There was a problem hiding this comment.
I've created a new commit that adds a null check to the drawable and context. Is this okay?
haroldadmin
force-pushed
the
development
branch
2 times, most recently
from
d0f2afe to
8b1e98f
Compare
|
@nikit19 @codepoet2017390 This commit incorporates the requested changes. Please review and confirm. |
|
Yes the project maintainers will take care of that further |
haroldadmin
force-pushed
the
development
branch
from
5c54f0f to
8b1e98f
Compare
|
Looks good code wise. |
This commit adds the logic for loading user avatar in EditProfileFragment. The fragment now reflects the actual avatar of the user when they are editing their profile.
haroldadmin
force-pushed
the
development
branch
from
8b1e98f to
edfec68
Compare
haroldadmin
changed the title
haroldadmin
changed the title
|
@nikit19 I have amended the commit title and the PR title accordingly. Thanks for the feedback 😊 |
|
So the PR is now accepted and will be merged? Woohoo! Thanks for the help @codepoet2017390 @iamareebjamal @nikit19 😊 This was my first pull request to an open source project. Looking forward to contributing more! |
4 participants
Fixes #653
Changes: Added logic to load the user's profile avatar in the EditProfileFragment.
Screenshots for the change:
