chore: Switch to Gradle 3.2.1 and support for build tools v28 to travis #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issue fossasia#659. This is a fix for unsupported gradle version error in android studio. This commit switches to Gradle v3.2.1 and adds support for build tools v28 to travis.yml so that builds using this gradle version don't fail on Travis CI.
iamareebjamal
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for unsupported gradle version error in Android Studio. Switching to Gradle v3.2.1 resolves this error, but causes the Travis CI builds to fail because the current travis.yml file does not allow support for build tools v28. Therefore, travis.yml file has also been modified to accept build tools v28.
Fixes #659
Changes: