fix: Improve code logic to handle no connectivity better on home screen #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify code logic to handle no connectivity better on refresh by showing the no internet card instantaneously, hiding the refreshing layout and not initiating non required calls to network methods.
aleronarjun
changed the title
nikit19
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify code logic to handle no connectivity better on refresh by showing the no internet card instantaneously, hiding the refreshing layout and not initiating non required calls to network methods.
Fixes #691
Changes:
The code logic has been modified to handle the issue mentioned.
Screenshots for the change:
Before:
Refreshing the event list (one fully loaded) under no internet:
(This state remains for a long time as the connection methods are called, and finally terminates after 8-10 secs with a toast)
After making the changes, and refreshing the events list (once fully loaded) under no internet: