chore: Toast notification text for successful login #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Toast notification text to " welcome back ! " From " success ".
Member
simarsingh24
left a comment
simarsingh24
left a comment
There was a problem hiding this comment.
Store it in strings file and reference it here
simarsingh24
suggested changes
Nov 20, 2018
|
|
||
| loginActivityViewModel.loggedIn.observe(this, Observer { | ||
| Toast.makeText(context, "Welcome back!", Toast.LENGTH_LONG).show() | ||
| val loggedIn: String = getString(R.string.logged_in) |
Member
There was a problem hiding this comment.
no need to create temp var
nikit19
reviewed
Nov 20, 2018
app/src/main/res/values/strings.xml
Outdated
| <string name="confirm_password">Confirm Password</string> | ||
| <string name="first_name_optional">First Name (Optional)</string> | ||
| <string name="last_name_optional">Last Name (Optional)</string> | ||
| <string name="logged_in">Welcome back!</string> |
Member
There was a problem hiding this comment.
You can name it welcome or welcome_back to avoid confusion
nikit19
approved these changes
Nov 21, 2018
simarsingh24
approved these changes
Nov 21, 2018
iamareebjamal
approved these changes
Nov 21, 2018
iamareebjamal
requested changes
Nov 21, 2018
Member
iamareebjamal
left a comment
iamareebjamal
left a comment
There was a problem hiding this comment.
Make the pull according to semantic standards
Abhimanyu121
changed the title
Member
codepoet2017390
left a comment
codepoet2017390
left a comment
There was a problem hiding this comment.
Please squash your commits
iamareebjamal
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Toast notification text to " Welcome back ! " From " success ".
Fixes #697