fix: Refactor ViewModels and their instances across the project #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
approved these changes
Dec 22, 2018
simarsingh24
approved these changes
Dec 22, 2018
Contributor
Author
|
Why does this PR show that "some checks were not successful. Not up to standards. This pull request quality could be better "? How is the quality of a pull request improved? |
Member
|
https://app.codacy.com/app/dreadpool2/open-event-android-general/pullRequest?prid=2781839
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #754
Changes: The ViewModel classes,their created instances and all their usages have been refactored according to convention by removing the term "Fragment" from them. The ViewModels changed:
attendeeFragmentViewModel -> attendeeViewModel (instances only)
ProfileFragmentViewModel -> ProfileViewModel (class and instances)
LoginFragmentViewModel -> LoginViewModel (class and instances)
ProfileFragmentViewModel -> ProfileViewModel (class and instances)
SignUpFragmentViewModel -> SignUpViewModel (class and instances)
SettingsFragmentViewModel -> SettingsViewModel (class only)