chore: Migrate to AndroidX and Koin 1.X #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamareebjamal
force-pushed
the
androidx
branch
from
c4c27b3 to
2384ee6
Compare
nikit19
previously approved these changes
Dec 25, 2018
simarsingh24
previously approved these changes
Dec 25, 2018
Member
|
Why build is failing? |
nikit19
reviewed
Dec 25, 2018
|
|
||
| android { | ||
| compileSdkVersion 27 | ||
| compileSdkVersion 28 |
Member
There was a problem hiding this comment.
I guess travis.yml needs to be updated as well
Member
Author
This is already there. But I'll check |
Member
Author
|
OK, so first it installs SDK 28, then overwrites it with 27. Great! |
iamareebjamal
dismissed stale reviews from simarsingh24 and nikit19
via
2a6f249
iamareebjamal
force-pushed
the
androidx
branch
2 times, most recently
from
2a6f249 to
1f44167
Compare
Member
Author
|
Also SearchFragment was not updated |
iamareebjamal
force-pushed
the
androidx
branch
from
1f44167 to
7fdafbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766