fix: Reposition sign in canceled Snackbar #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
reviewed
Jan 10, 2019
| app:layout_behavior="@string/appbar_scrolling_view_behavior" /> | ||
|
|
||
| <androidx.coordinatorlayout.widget.CoordinatorLayout | ||
| android:id="@+id/mainSnackbar" |
Member
There was a problem hiding this comment.
you are naming the CoordinatorLayout as mainSnackbar Why?
Contributor
Author
There was a problem hiding this comment.
That coordinatorLayout is being used to show the snackbar in the main activity. What should i rename it to?
GOVINDDIXIT
reviewed
Jan 10, 2019
| import com.google.android.material.snackbar.Snackbar | ||
| import kotlinx.android.synthetic.main.activity_main.navigation | ||
| import kotlinx.android.synthetic.main.activity_main.navigationAuth | ||
| import kotlinx.android.synthetic.main.activity_main.* |
Contributor
Author
There was a problem hiding this comment.
Thanks! Will replace it with multiple imports
addiegupta
force-pushed
the
development
branch
from
07ac49b to
1bf5254
Compare
Contributor
Author
|
I have pushed another commit please review |
| <androidx.coordinatorlayout.widget.CoordinatorLayout | ||
| android:id="@+id/mainSnackbarCoordinatorLayout" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content"/> |
Member
There was a problem hiding this comment.
Not good, make it the wrapping element
Contributor
Author
There was a problem hiding this comment.
I have pushed another commit. Please let me know if I still need to make changes to this
addiegupta
force-pushed
the
development
branch
from
1bf5254 to
a6eb826
Compare
iamareebjamal
approved these changes
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #869
Changes:
The snackbar is now visible above the bottom navigation view
Screenshots for the change: