feat: Add welcome fragment for asking location first time #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikit19
approved these changes
Jan 15, 2019
Member
|
As a follow up, please create an issue to polish this implementation. I'll review what needs to be changed |
| android:text="@string/pick_a_city" | ||
| android:textColor="@android:color/white" | ||
| app:backgroundTint="@color/colorPrimary" /> | ||
| </RelativeLayout> |
Member
There was a problem hiding this comment.
Make this a contraint layout
|
|
||
| fun saveSearch(query: String) { | ||
| preference.putString(tokenKey, query) | ||
| preference.putBoolean(LOCATION_SAVED, true) |
Member
There was a problem hiding this comment.
Instead, can't we save the location itself?
| setupBottomNavigationMenu(navController) | ||
|
|
||
| if (!preference.getBoolean(LOCATION_SAVED, false)) | ||
| navController.navigate(R.id.welcomeFragment) |
Member
There was a problem hiding this comment.
We haven't done this lately, but all logic goes in ViewModel so that it is testable.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #818