fix: all tickets are not showing in ticket-fragment in landscape mode #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… landscape mode changed the parent element from ScrollView to NestedScrollView added android:descendantFocusability="blocksDescendants" property to get the scoll position to top every time orientation changed fixed :fossasia#986
GOVINDDIXIT
reviewed
Jan 31, 2019
Member
GOVINDDIXIT
left a comment
GOVINDDIXIT
left a comment
There was a problem hiding this comment.
mention issue in PR description not in PR title
pranavpandey1998official
changed the title
nikit19
approved these changes
Jan 31, 2019
iamareebjamal
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the parent element from ScrollView to NestedScrollView in ticket_fragment
added android:descendantFocusability="blocksDescendants" property to get the scroll position to top every time orientation changed
fixed: #988