feat: Remove all explicit intents and use safe args for search date #999
Conversation
liveHarshit
force-pushed
the
development
branch
from
d5d50a5 to
ff26908
Compare
liveHarshit
changed the title
liveHarshit
force-pushed
the
development
branch
from
ff26908 to
bd68cc8
Compare
liveHarshit
changed the title
| fun loadTimeAndLocation() { | ||
| savedLocation = preference.getString(tokenKey) | ||
| savedDate = preference.getString(SearchTimeViewModel.tokenKeyDate) | ||
| } |
There was a problem hiding this comment.
This is not what I meant. We should not be storing transient variables in SharedPreferences. Read about Type Safe Navigation Arguments
There was a problem hiding this comment.
@GOVINDDIXIT Official documentation is here: https://codelabs.developers.google.com/codelabs/android-navigation/#7
There was a problem hiding this comment.
This is not what I meant. We should not be storing transient variables in SharedPreferences. Read about Type Safe Navigation Arguments
Okay, but then how to store user saved location and date without preferences.
There was a problem hiding this comment.
Store the location, no issue. Why do you need to store date?
liveHarshit
force-pushed
the
development
branch
from
bd68cc8 to
5161484
Compare
liveHarshit
changed the title
|
Updated. |
|
Aren't we passing more intent extras? |
yes, there are not main activity intenets anymore. |
3 participants
Fixes #997
Fixes #998
Fixes #1047