This repository was archived by the owner on Oct 9, 2020. It is now read-only.
  
  
  - 
                Notifications
    
You must be signed in to change notification settings  - Fork 823
 
fix: Fix crashing OSMapFragment (#1389) #1390
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           @amitiwary999 Please follow the commit style guideline. Your commit should look like this. 
  | 
    
| 
           @amitiwary999 You changed the PR name. Please change the commit name as well. See this  | 
    
| 
           @the-dagger Please take a look  | 
    
    
  rohanagarwal94 
      pushed a commit
        to rohanagarwal94/open-event-android
      that referenced
      this pull request
    
      Apr 27, 2017 
    
    
  
    
  the-dagger 
      pushed a commit
      that referenced
      this pull request
    
      Jun 17, 2017 
    
    
      
  
    
      
    
  
* Issue #1155 UI of Schedule Screen improved. (#1165) * Update JSON assets and API endpoints This commit updates the API endpoints and JSON assets of Open Event Android app according to FOSSASIA-17 Summit. * Check for null values in microlocation field of Session JSON * Correct speaker URL in SpeakerListAdapter and Speaker POJO class This commit solves the problem of speaker images not being loaded in speaker fragment, session detail and speaker detail Activities. * Session Layout Fixed Fix issue#1130 (#1184) * Fixed issue #1179 ui bug in session detail activity (#1181) * fix: Speaker's biographic details (#1194) * docs: Add Commit style guidelines (#1191) * added start/end attributes for each left/end ones (#1189) * added speaker name in session list item (#1178) * Tabs Centred (#1075) * fix: Font size of text on Speaker's image (#1197) * chore: update upload-apk.sh to reduce repo size * Fixed issue #1187 UI Bug: on back pressed in map opens last fragment/activity instead of session activity (#1190) Signed-off-by: Rishabh Khanna <rishabhkhanna777@gmail.com> docs: Add Commit style guidelines (#1191) added start/end attributes for each left/end ones (#1189) added speaker name in session list item (#1178) Tabs Centred (#1075) fix: Font size of text on Speaker's image (#1197) * Fix: App crashing in bookmarks fragment. (#1203) * Fix: navigation drawer lag #1173 (#1200) * Bookmarks Item in navigation drawer remains clicked if no bookmarks present (#1177) * Fix: Issue #1176 App crashing on data connection. (#1186) * fixes for FOSSASIA 2017 (#1226) Changes to make app working with FOSSASIA 2017 * Fix: Showing result based on query after refresh (#1221) * Fix: Correcting Map Location (#1220) * fixes issue#1222 (#1229) * fix: removing html tags from scheduleFragment * fix: UI bug in speakerlist and speakerDetailsActivity (#1209) * Fix: Corrected the grid layout when screen is rotated (#1208) * html parsing issue solved, Issue #1185 (#1201) * fix: UI bug in session card in SpeakerDetailActivity (#1214) * Bookmarks Issue Fixed (#1081) (#1098) * Bookmarks Issue Fixed (#1081) * Update build.gradle * Update SessionsListAdapter.java * fix: updated kubernetes.md * Fixes #1251 (#1252) * Remove API key from code (#1253) * fix: Access to package method in DatabaseTest Fixes #1255 * fix: issue bookmark status in SpeakerDetailsActivity resolved * update: Change in description field variable in DayScheduleAdapter. (#1263) * Shared messages (#1273) * updated bookmark string error * fixed error in shared events * updated bookmark string error (#1272) * docs: Updated documentation to setup Maps. (#1258) * docs: Updated screenshots. (#1249) * fix: issue Sort Sponsors according to sponsorship level * spelling fixes * Make application asynchronous using Rx (for #1269) (#1276) * Make database operations reactive (for #1269) * Fix merge conflicts (for #1269) * feat: Add sticky headers in the recyclerview(trackRecyclerview) * fix: fix PMD issues * enchancement: Update Developed by FOSSASIA instead of Programmed by FOSSASIA (#1284) * feat: Add sticky headers in the dayRecyclerVew Display slots between time headers for better UI and UX * Move bookmark and share icon to bottom (#1298) Move the bookmark and share icon to bottom of the tracks item header * fix: Change headers along with Sort Order in RecyclerView This will change headers when you change sort order. * update: Change layout of schedule item Makes schedule item more readable * feat: Make remaining fragments reactive (#1295) * feat: Add headers in the locationsRecyclerView * fix: fix PMD issues * fix: bug in item selection in navigation drawer resolved (#1307) * fix: Remove redundant menu item tinting code (#1305) Now, we use a shaded scrim to make text and icons visible, so there is no need to dynamically tint menu icons. Also, reactively loading speaker from db means it may result in NullPointerException * fix: loading of SpeakerImage in SpeakerDetialsActivity resolved (#1285) * chore : change the default value for data toggle Data is downloaded on mobile data too by default. * Download data on mobile network by default (#1309) * chore : download data on mobile data by default * feat : download data on mobile network by default * feat: Make refresh and download action asynchronous (#1316) * Make the refresh action in fragments asynchronous using RxJava * Make the connection checking process asynchronous * Make the database writing operation asynchronous after download Fixes #1315 * fix: display cached sponser images when offline (#1314) * fix: Fix layout warnings and RTL (#1303) * fix: Fix layout warnings and RTL Fix the layout warnings, RTL support and add tools attribute for development aide Fixes #1296 * Resolve merge conflicts on layout * fix: resolved crashing in SpeakerDetailsActivity (#1313) * Fix: Arraylist not cleared before adding items (#1317) * Leaks, blocks and NPE fixes (#1320) * fix: Fix receiver leak and add connection listener * fix: Fix leaks and NullPointerExceptions * fix: Fix blocking of SponsorsFragment * fix: App crashing due to OutOfMemory error in loading Bitmap (#1261) * fix:Added Notification Interval Title in Settings (#1248) * fix:Missing Logo in Bookmark Widget added(#1300) (#1327) * enhancement: Change speaker layout in Session Detail (#1333) Fixes #1332 * fix: Fix drawer layout lag (#1330) Use hardware acceleration and fixed navigation bar width to fix lag * Fix/Avoid observable leaks in activities and adapters (#1329) * fix: Fix memory leak by disposing observables in Activities * fix: Fix memory leak disposing observables in Adapters * fix: Fix speaker image not loading for first time (#1325) Picasso holds a weak reference to Target object being used to load speaker photo which gets garbage collected by the time image is loaded. To prevent this, make the Target final and to make it a strong reference, add it to a view lifecycle Fixes #1321 * fix: Re-enable hardware acceleration for shadows (#1335) * fix: Fixed Bookmark snackbar. (#1245) * Fixes offline download (#1336) * bumped to 1.0.0 (#1337) * feat: About Page for application (#1283) * Schedule timings fixed * Removes Home * fix : remove instances of nav_home * feat: Add selectable item background to borderless buttons (#1362) * fix: Remove translatable string warnings (#1359) * fix: Upgrade libraries and use absolute versions (#1360) * improved location fragment ui (#1358) * fix: StartTime default sort for sessions (#1346) * fix: fixes Layout Breaking in landscape mode #1331 (#1364) * fix: Hide track description if not present (#1383) Fixes #1382 * fix: Fix memory leaks by removing static context (#1381) Remove unnecessary static context from classes preventing memory leak. Instead, wrap them in WeakReference wherever possible * fix: Remove redundant imports and warnings (#1380) * fix: Fix widget layout warnings and rendering pre lollipop (#1379) - Change vector drawable to raster - Remove deprecations and warnings Fixes #1378 * fix: Fix share menu option crashing (#1393) * chore: Update app screenshots in ReadMe (#1395) * feat: Improve SpeakerDetailActivity collapsing toolbar (#1392) - Improve top and bottom scrim - Render designation and organization correctly Fixes #1391 * fixes issue #1389 (#1390) * refactor: rename method names to meaningful names with camel case convention in Database operations (#1398) * fix: Use thumbnail attribute for Speaker API (#1371) Use `thumbnail` attribute from Speaker API to show thumbnails instead of photo Using `photo` attribute for displaying images in SpeakerListFragment or Event Detail Activity consumes large amount of data as full size images need to be downloaded. Using server side resized images by using `thumbnail` or `icon` attribute saves from downscaling these photos by a 3rd party application. Fixes #1264 * feat: Add stetho library for debugging (#1401) Stetho library integration with Retrofit and Picasso along w ith Database and SharedPreference debugging Fixes #1396 * feat: Update Back Button of Section Other Than Tracks (#1373) * Update README.md * Update upload-apk.sh * Update codestyle.md * refactor: Break MainActivity methods into maintainable blocks (#1370) Breaks the monolithic and large methods into maintainable functions * Revert "refactor: Break MainActivity methods into maintainable blocks (#1370)" (#1403) This reverts commit 3154df8. * fix : fix app crashing when first time running app without downloding latest schedule (#1411) * fix : make appbar always expanded and optimise code for it (#1408) * fix: bug related to bookmarks (#1413) fix: bug related to bookmarks * feat: Adding feature to filter schedule * Switch to staging-cluster * feat: Make UI follow track colors (#1420) Fixes #1405 * fix : search not working properly in track session activity (#1424) * Create apk-generator.md * fix: Fix session colors not showing in Location wise sessions (#1431) * fix: Fix notification replace strategy (#1430) * Update apk-generator.md - Added delivery options * fix: Show correct event logo in Navigation View * Modify json result structure and add keystore info to docker environment (#1453) * fix: Cache computed color to avoid delay Cache calculated colors so the delay in Track color UI update is minimized Fixes #1452 * fix: Ensure International English Punctuation across the app (#1457) Fixes #1451 * fix: showed actual dates in the Schedule Viewpage Adapter (#1454) * docs: Add app build details in apk-generator.md Add details about the app generation process in web app Fixes #1436 * Fixes 1435: Document getting the data from uploaded zip/url * Refer screenshots locally from project * feat : Implement sort by tracks option in Schedule Fragment (#1415) * feat : Add strings for Sort by title for Schedule Fragment Add strings for sort by title in arrays.xml and strings.xml Rename strings for existing sort methods to meaningful name * feat : Add sort by tracks option in Day Schedule Fragment * fix : Sort sticky headers in alphabetical order in Day Schedule Fragment when sort mode is by tracks * Update DayScheduleFragment.java * Update DayScheduleFragment.java * Update DayScheduleFragment.java * Update DayScheduleFragment.java * Update DayScheduleFragment.java * docs: Add doc images locally (#1463) - Add all images in /docs/images/ - Remove stale images - Add /docs/screenshots/deleted.txt for future references * Fixed SessionDetailActivity AppBarLayout not collapsing appropriately (#1469) * fix: Remove unnecessary share links (#1470) - Remove share links from session item and update UI accordingly - Remove generic app link information from speaker detail - Add StringUtils function to join a list into string using a delimiter - Add speaker information in session share link Fixes #1442 * feat: Enable Leak Canary to report memory leaks and fix them (#1471) Fixes #1465 * fix: timezone while parsing the date from API (#1473) * docs: Add repo size reduction apk upload doc (#1478) Fixes #1433 * fix: Remove share from SpeakerListActivity (#1482) Fixes #1442 * removed padding from fragment_bookmarks.xml (#1486) * fix : search when sort option is changed (#1483) * fix: Shorten dates in ScheduleFragment (#1495) Fixes #1480 * update support lib and gradle plugin (#1481) * update support lib and gradlew plugin * Update build.gradle * fix: resolved the memory leak in DayScheduleFragment (#1498) * fix:Settings Page Animation fixed and Settings Descriptions Added(#1444) (#1488) * fix: removed disappearence of menu icons (#1477) * scrollable tab in schedule fragment (#1502) * Fixes message sharing issue (#1506) fix : message sharing issue * style: Center alignment of the speaker details in the recyclerview in content_session_detail.xml (#1508) Fixes issue #1487 * fix : Add view pager margin and move sort option to actionbar (#1507) * feat : Add view pager margin in ScheduleFragment * fix : Move sort option from FAB to actionbar * fix: Inconsistent state of app when download interrupted (#1500) Fixes #1497 * Fix : search not working properly in locationactivity and bookmarksfragment (#1474) * fix: Remove unnecessary drawer menu load and clear (#1523) * fix: Network not available dialog disappears when network is available (#1520) * fix: Network not available alert dialog box disappears when network is available Fixes issue #1505 * Remove redundant import statements * Remove redundant import statements from MainActivity * Correct indentation in OpenEventApp * Change name of variable from dialog to dialogNetworkNotiff * fix: Network state change crash (#1515) * Added Milestone to template (#1525) * Update ISSUE_TEMPLATE * Fixed template typo. (#1530) * Sponsor name added (#1516) * fix: Thumbnail NullPointerException check (#1519) Fixes #1517 * fix: Center align empty text in LocationActivity (#1536) * feat : add locations in map (googlePlay) (#1535) * fix : wrong dates displayed in ScheduleFragment (#1547) * fix: Align tabs in ScheduleFragment (#1545) * feat: Share button updated (#1533) * fix: Use 12 hour time representation (#1538) * Managing error in represenation of time * Removing earlier changes and adjusting ISO conversions * fix: displayed toolbar for map icon click (#1532) * feat: added map icon in location activity (#1503) * fix : Displaying same time for session when timezone is changed (#1553) * feat: Save splash logo during apk generation (#1556) * Push docker images to public docker repo * feat: Replace callbacks to lambda in remaining parts (#1572) * fix: add sort option for org and country only when needed (#1563) * OSX docs for generic installation of app generator (#1575) * OSX docs for generic installation of app generator * Update generic.md * fix: getting event info from the assets folder (#1562) * style : Hide subtitle if it is empty (#1580) Fixes #1579 * Throw exceptions properly and replace unzip method * Add additional logging statements for celery * Use new secret to store droidgen tls and contact redis via dns * Changing the edge glow color of scrollview in Session Detail Activity (#1581) * Revert "fix: updated kubernetes.md" * docs: Update generic.md to include additional info (#1589) * feat: Replace callbacks with lambdas in adapters (#1569) * feat: Replace callbacks to lambda in fragments (#1571) * feat: Add retrolambda and replace callback in activities (#1568) * feat: Replace callbacks to lambda in DbInstance (#1570) * docs: Align screenshots in ReadMe (#1607) * Add branding * Add kubernetes deployment docs. * Fix incorrect syntax and region * fix : App crashing on starting when generated using api endpoint * fix : Remove redundant files from assets * Specify version to kubernetes docs * refactor : Fix codacy issues for generic android app (#1614) * fix : code style issue * fix : Remove unused fields and imports * fix : Other codacy issues * fix : explicit scop issues * fix : Add comments in default block and rename variable * fix: Change collection lambda and add remaining (#1623) * fix: NullPointerException in parsing Sessions of Speakers (#1621) * fix: Shadow between AppBar and TabLayout (#1599) * fix: Resize splash logo to appropriate size (#1632) Resize the splash logo shown at app launch to appropriate size maintaining the aspect ratio of the image Fixes #1591 * Fixes 1419 : Enhance Google PLay map fragment (#1625) * refactor : Fix codacy issues in app generator v2 (#1634) * feat: Migrate to Realm (#1509) * fix: Show disappeared markers in Realm build (#1638) * Fixes #1628 : Revert app sharing workflow (#1635) * refactor: Rewrite ISO8601Date class (#1617) * feat:Added Track Tags in Schedule(#1521) (#1640) * back button in location activity made working (#1642) * feat: Change edge glow color of RecyclerView of tracks and sessions speaker activity (#1629) * test: Add date conversion tests (#1566) * fix: Show speaker image placeholder under no network (#1647) * fix: Disappearing map icon and map fragment overlay (#1645) * feat: Show progress bar dialog while downloading event data (#1630) - Create DownloadCompleteHandler for handling download events - Create fluent API for DownloadCompleteHandler - Remove download related events from MainActivity - Handle events ro show progress of download - Propagate success or error to MainActivity using CompletableSubject - Hide/Show progressbar at appropriate events Fixes #1490 * fix : App generated using zip is not able to fetch latest data * Move android generator to eventyay-cluster * feat: Ignore build/generated folders while copying in generator (#1665) * fix: Add JSON payload images in apk - Add speaker and sponsor images in apk - Add option to load images from asset URI via Picasso - Add tests for URI converter * chore: Move Date tests from androidTest/ to test/ (#1669) * chore: Move Date tests from androidTest/ to test/ * corrected DateTest.java file (#3) * Update README.md * fix: Remove description and location attributes from Track (#1674) * fix : Save event date in database when loading from assets (#1675) * fix: Lenient parsing and error handling throughout the app (#1663) * fix: Date format and parsing along with unit tests (#1683) * feat:Added bookmarks in Schedule Page (#1685) Remove unused imports Fixed Codacy Issues Fixed Codacy Issues Added minor fix * feat: added a video button in SessionDetailActivity.java (#1686) * feat: New Home Screen with bookmarks and Global Search (#1565) feat:Global Search Added along with Bookmarks added to Home Page(#1499) Removed Unused Imports Minor Fixes Restructuring of the ViewHolders done to enable resusability of Code Minor Fixes related to Codacy Improved Search Speed Added improvements from developemt Removed unused imports File formatting done feat: Make color usage and layout normalized Added tags dissappearance * feat : Cache sponsor images and speaker's thumbnails (#1684) * fix : App crashing when connected to network but internet is not working (#1513) * fix: Sort sponsors according to level in ascending order (#1694) * fix: Hide sessions in draft state (#1692) * fix : App behaviour when api url is not available for event (#1690) Directly load data from assets without showing dialogue Disable swipe refresh layout * Revert "fix: Sort sponsors according to level in ascending order (#1694)" This reverts commit 70cae37. * chore: Remove Bookmark Fragment and fragment_bookmarks.xml (#1698) * fix: Update local json with new date format and add verbose logging * fix: Use common bookmark icon throughout app (#1696) * fix: maintaining text size throughout the app (#1707) * fix: maintaining text size throughout the app * fix: maintained uniform text size of elements throughout the app * Improving the map fragment for play version (#1668) Improving the map fragment for play version Improving the map fragment for play version Improving the map fragment for play version Improving the map fragment for play version Changing the title bar hint color for map * no sessions text handled in location activity (#1653) * Create CODE_OF_CONDUCT.md * fix: Add new DateUtils fixing local and event dates (#1700) * feat: added a two pane layout (#1590) * fix: Show loading progress while parsing local JSON assets (#1704)
    
  vidu171 
      pushed a commit
        to vidu171/open-event-android
      that referenced
      this pull request
    
      Jan 29, 2018 
    
    
      
  
    
      
    
  
Updated deploy script path Updated google cloud service account key Update generic.md Remove deployment from main branches Changing the list dividers and ripples (fossasia#1052) Replacing the dividers in track list, location list, sponsors list and schedule list. Also added the lost ripple in some parts and changed the color of toolbar title of the locations activity. Issue fossasia#1045 Name of track not displaying on clicking the notification when session is bookmarked resolved. (fossasia#1053) Took out Digital Ocean Merge development to master (fossasia#1716) * Issue fossasia#1155 UI of Schedule Screen improved. (fossasia#1165) * Update JSON assets and API endpoints This commit updates the API endpoints and JSON assets of Open Event Android app according to FOSSASIA-17 Summit. * Check for null values in microlocation field of Session JSON * Correct speaker URL in SpeakerListAdapter and Speaker POJO class This commit solves the problem of speaker images not being loaded in speaker fragment, session detail and speaker detail Activities. * Session Layout Fixed Fix issue#1130 (fossasia#1184) * Fixed issue fossasia#1179 ui bug in session detail activity (fossasia#1181) * fix: Speaker's biographic details (fossasia#1194) * docs: Add Commit style guidelines (fossasia#1191) * added start/end attributes for each left/end ones (fossasia#1189) * added speaker name in session list item (fossasia#1178) * Tabs Centred (fossasia#1075) * fix: Font size of text on Speaker's image (fossasia#1197) * chore: update upload-apk.sh to reduce repo size * Fixed issue fossasia#1187 UI Bug: on back pressed in map opens last fragment/activity instead of session activity (fossasia#1190) Signed-off-by: Rishabh Khanna <rishabhkhanna777@gmail.com> docs: Add Commit style guidelines (fossasia#1191) added start/end attributes for each left/end ones (fossasia#1189) added speaker name in session list item (fossasia#1178) Tabs Centred (fossasia#1075) fix: Font size of text on Speaker's image (fossasia#1197) * Fix: App crashing in bookmarks fragment. (fossasia#1203) * Fix: navigation drawer lag fossasia#1173 (fossasia#1200) * Bookmarks Item in navigation drawer remains clicked if no bookmarks present (fossasia#1177) * Fix: Issue fossasia#1176 App crashing on data connection. (fossasia#1186) * fixes for FOSSASIA 2017 (fossasia#1226) Changes to make app working with FOSSASIA 2017 * Fix: Showing result based on query after refresh (fossasia#1221) * Fix: Correcting Map Location (fossasia#1220) * fixes issue#1222 (fossasia#1229) * fix: removing html tags from scheduleFragment * fix: UI bug in speakerlist and speakerDetailsActivity (fossasia#1209) * Fix: Corrected the grid layout when screen is rotated (fossasia#1208) * html parsing issue solved, Issue fossasia#1185 (fossasia#1201) * fix: UI bug in session card in SpeakerDetailActivity (fossasia#1214) * Bookmarks Issue Fixed (fossasia#1081) (fossasia#1098) * Bookmarks Issue Fixed (fossasia#1081) * Update build.gradle * Update SessionsListAdapter.java * fix: updated kubernetes.md * Fixes fossasia#1251 (fossasia#1252) * Remove API key from code (fossasia#1253) * fix: Access to package method in DatabaseTest Fixes fossasia#1255 * fix: issue bookmark status in SpeakerDetailsActivity resolved * update: Change in description field variable in DayScheduleAdapter. (fossasia#1263) * Shared messages (fossasia#1273) * updated bookmark string error * fixed error in shared events * updated bookmark string error (fossasia#1272) * docs: Updated documentation to setup Maps. (fossasia#1258) * docs: Updated screenshots. (fossasia#1249) * fix: issue Sort Sponsors according to sponsorship level * spelling fixes * Make application asynchronous using Rx (for fossasia#1269) (fossasia#1276) * Make database operations reactive (for fossasia#1269) * Fix merge conflicts (for fossasia#1269) * feat: Add sticky headers in the recyclerview(trackRecyclerview) * fix: fix PMD issues * enchancement: Update Developed by FOSSASIA instead of Programmed by FOSSASIA (fossasia#1284) * feat: Add sticky headers in the dayRecyclerVew Display slots between time headers for better UI and UX * Move bookmark and share icon to bottom (fossasia#1298) Move the bookmark and share icon to bottom of the tracks item header * fix: Change headers along with Sort Order in RecyclerView This will change headers when you change sort order. * update: Change layout of schedule item Makes schedule item more readable * feat: Make remaining fragments reactive (fossasia#1295) * feat: Add headers in the locationsRecyclerView * fix: fix PMD issues * fix: bug in item selection in navigation drawer resolved (fossasia#1307) * fix: Remove redundant menu item tinting code (fossasia#1305) Now, we use a shaded scrim to make text and icons visible, so there is no need to dynamically tint menu icons. Also, reactively loading speaker from db means it may result in NullPointerException * fix: loading of SpeakerImage in SpeakerDetialsActivity resolved (fossasia#1285) * chore : change the default value for data toggle Data is downloaded on mobile data too by default. * Download data on mobile network by default (fossasia#1309) * chore : download data on mobile data by default * feat : download data on mobile network by default * feat: Make refresh and download action asynchronous (fossasia#1316) * Make the refresh action in fragments asynchronous using RxJava * Make the connection checking process asynchronous * Make the database writing operation asynchronous after download Fixes fossasia#1315 * fix: display cached sponser images when offline (fossasia#1314) * fix: Fix layout warnings and RTL (fossasia#1303) * fix: Fix layout warnings and RTL Fix the layout warnings, RTL support and add tools attribute for development aide Fixes fossasia#1296 * Resolve merge conflicts on layout * fix: resolved crashing in SpeakerDetailsActivity (fossasia#1313) * Fix: Arraylist not cleared before adding items (fossasia#1317) * Leaks, blocks and NPE fixes (fossasia#1320) * fix: Fix receiver leak and add connection listener * fix: Fix leaks and NullPointerExceptions * fix: Fix blocking of SponsorsFragment * fix: App crashing due to OutOfMemory error in loading Bitmap (fossasia#1261) * fix:Added Notification Interval Title in Settings (fossasia#1248) * fix:Missing Logo in Bookmark Widget added(fossasia#1300) (fossasia#1327) * enhancement: Change speaker layout in Session Detail (fossasia#1333) Fixes fossasia#1332 * fix: Fix drawer layout lag (fossasia#1330) Use hardware acceleration and fixed navigation bar width to fix lag * Fix/Avoid observable leaks in activities and adapters (fossasia#1329) * fix: Fix memory leak by disposing observables in Activities * fix: Fix memory leak disposing observables in Adapters * fix: Fix speaker image not loading for first time (fossasia#1325) Picasso holds a weak reference to Target object being used to load speaker photo which gets garbage collected by the time image is loaded. To prevent this, make the Target final and to make it a strong reference, add it to a view lifecycle Fixes fossasia#1321 * fix: Re-enable hardware acceleration for shadows (fossasia#1335) * fix: Fixed Bookmark snackbar. (fossasia#1245) * Fixes offline download (fossasia#1336) * bumped to 1.0.0 (fossasia#1337) * feat: About Page for application (fossasia#1283) * Schedule timings fixed * Removes Home * fix : remove instances of nav_home * feat: Add selectable item background to borderless buttons (fossasia#1362) * fix: Remove translatable string warnings (fossasia#1359) * fix: Upgrade libraries and use absolute versions (fossasia#1360) * improved location fragment ui (fossasia#1358) * fix: StartTime default sort for sessions (fossasia#1346) * fix: fixes Layout Breaking in landscape mode fossasia#1331 (fossasia#1364) * fix: Hide track description if not present (fossasia#1383) Fixes fossasia#1382 * fix: Fix memory leaks by removing static context (fossasia#1381) Remove unnecessary static context from classes preventing memory leak. Instead, wrap them in WeakReference wherever possible * fix: Remove redundant imports and warnings (fossasia#1380) * fix: Fix widget layout warnings and rendering pre lollipop (fossasia#1379) - Change vector drawable to raster - Remove deprecations and warnings Fixes fossasia#1378 * fix: Fix share menu option crashing (fossasia#1393) * chore: Update app screenshots in ReadMe (fossasia#1395) * feat: Improve SpeakerDetailActivity collapsing toolbar (fossasia#1392) - Improve top and bottom scrim - Render designation and organization correctly Fixes fossasia#1391 * fixes issue fossasia#1389 (fossasia#1390) * refactor: rename method names to meaningful names with camel case convention in Database operations (fossasia#1398) * fix: Use thumbnail attribute for Speaker API (fossasia#1371) Use `thumbnail` attribute from Speaker API to show thumbnails instead of photo Using `photo` attribute for displaying images in SpeakerListFragment or Event Detail Activity consumes large amount of data as full size images need to be downloaded. Using server side resized images by using `thumbnail` or `icon` attribute saves from downscaling these photos by a 3rd party application. Fixes fossasia#1264 * feat: Add stetho library for debugging (fossasia#1401) Stetho library integration with Retrofit and Picasso along w ith Database and SharedPreference debugging Fixes fossasia#1396 * feat: Update Back Button of Section Other Than Tracks (fossasia#1373) * Update README.md * Update upload-apk.sh * Update codestyle.md * refactor: Break MainActivity methods into maintainable blocks (fossasia#1370) Breaks the monolithic and large methods into maintainable functions * Revert "refactor: Break MainActivity methods into maintainable blocks (fossasia#1370)" (fossasia#1403) This reverts commit 3154df8. * fix : fix app crashing when first time running app without downloding latest schedule (fossasia#1411) * fix : make appbar always expanded and optimise code for it (fossasia#1408) * fix: bug related to bookmarks (fossasia#1413) fix: bug related to bookmarks * feat: Adding feature to filter schedule * Switch to staging-cluster * feat: Make UI follow track colors (fossasia#1420) Fixes fossasia#1405 * fix : search not working properly in track session activity (fossasia#1424) * Create apk-generator.md * fix: Fix session colors not showing in Location wise sessions (fossasia#1431) * fix: Fix notification replace strategy (fossasia#1430) * Update apk-generator.md - Added delivery options * fix: Show correct event logo in Navigation View * Modify json result structure and add keystore info to docker environment (fossasia#1453) * fix: Cache computed color to avoid delay Cache calculated colors so the delay in Track color UI update is minimized Fixes fossasia#1452 * fix: Ensure International English Punctuation across the app (fossasia#1457) Fixes fossasia#1451 * fix: showed actual dates in the Schedule Viewpage Adapter (fossasia#1454) * docs: Add app build details in apk-generator.md Add details about the app generation process in web app Fixes fossasia#1436 * Fixes 1435: Document getting the data from uploaded zip/url * Refer screenshots locally from project * feat : Implement sort by tracks option in Schedule Fragment (fossasia#1415) * feat : Add strings for Sort by title for Schedule Fragment Add strings for sort by title in arrays.xml and strings.xml Rename strings for existing sort methods to meaningful name * feat : Add sort by tracks option in Day Schedule Fragment * fix : Sort sticky headers in alphabetical order in Day Schedule Fragment when sort mode is by tracks * Update DayScheduleFragment.java * Update DayScheduleFragment.java * Update DayScheduleFragment.java * Update DayScheduleFragment.java * Update DayScheduleFragment.java * docs: Add doc images locally (fossasia#1463) - Add all images in /docs/images/ - Remove stale images - Add /docs/screenshots/deleted.txt for future references * Fixed SessionDetailActivity AppBarLayout not collapsing appropriately (fossasia#1469) * fix: Remove unnecessary share links (fossasia#1470) - Remove share links from session item and update UI accordingly - Remove generic app link information from speaker detail - Add StringUtils function to join a list into string using a delimiter - Add speaker information in session share link Fixes fossasia#1442 * feat: Enable Leak Canary to report memory leaks and fix them (fossasia#1471) Fixes fossasia#1465 * fix: timezone while parsing the date from API (fossasia#1473) * docs: Add repo size reduction apk upload doc (fossasia#1478) Fixes fossasia#1433 * fix: Remove share from SpeakerListActivity (fossasia#1482) Fixes fossasia#1442 * removed padding from fragment_bookmarks.xml (fossasia#1486) * fix : search when sort option is changed (fossasia#1483) * fix: Shorten dates in ScheduleFragment (fossasia#1495) Fixes fossasia#1480 * update support lib and gradle plugin (fossasia#1481) * update support lib and gradlew plugin * Update build.gradle * fix: resolved the memory leak in DayScheduleFragment (fossasia#1498) * fix:Settings Page Animation fixed and Settings Descriptions Added(fossasia#1444) (fossasia#1488) * fix: removed disappearence of menu icons (fossasia#1477) * scrollable tab in schedule fragment (fossasia#1502) * Fixes message sharing issue (fossasia#1506) fix : message sharing issue * style: Center alignment of the speaker details in the recyclerview in content_session_detail.xml (fossasia#1508) Fixes issue fossasia#1487 * fix : Add view pager margin and move sort option to actionbar (fossasia#1507) * feat : Add view pager margin in ScheduleFragment * fix : Move sort option from FAB to actionbar * fix: Inconsistent state of app when download interrupted (fossasia#1500) Fixes fossasia#1497 * Fix : search not working properly in locationactivity and bookmarksfragment (fossasia#1474) * fix: Remove unnecessary drawer menu load and clear (fossasia#1523) * fix: Network not available dialog disappears when network is available (fossasia#1520) * fix: Network not available alert dialog box disappears when network is available Fixes issue fossasia#1505 * Remove redundant import statements * Remove redundant import statements from MainActivity * Correct indentation in OpenEventApp * Change name of variable from dialog to dialogNetworkNotiff * fix: Network state change crash (fossasia#1515) * Added Milestone to template (fossasia#1525) * Update ISSUE_TEMPLATE * Fixed template typo. (fossasia#1530) * Sponsor name added (fossasia#1516) * fix: Thumbnail NullPointerException check (fossasia#1519) Fixes fossasia#1517 * fix: Center align empty text in LocationActivity (fossasia#1536) * feat : add locations in map (googlePlay) (fossasia#1535) * fix : wrong dates displayed in ScheduleFragment (fossasia#1547) * fix: Align tabs in ScheduleFragment (fossasia#1545) * feat: Share button updated (fossasia#1533) * fix: Use 12 hour time representation (fossasia#1538) * Managing error in represenation of time * Removing earlier changes and adjusting ISO conversions * fix: displayed toolbar for map icon click (fossasia#1532) * feat: added map icon in location activity (fossasia#1503) * fix : Displaying same time for session when timezone is changed (fossasia#1553) * feat: Save splash logo during apk generation (fossasia#1556) * Push docker images to public docker repo * feat: Replace callbacks to lambda in remaining parts (fossasia#1572) * fix: add sort option for org and country only when needed (fossasia#1563) * OSX docs for generic installation of app generator (fossasia#1575) * OSX docs for generic installation of app generator * Update generic.md * fix: getting event info from the assets folder (fossasia#1562) * style : Hide subtitle if it is empty (fossasia#1580) Fixes fossasia#1579 * Throw exceptions properly and replace unzip method * Add additional logging statements for celery * Use new secret to store droidgen tls and contact redis via dns * Changing the edge glow color of scrollview in Session Detail Activity (fossasia#1581) * Revert "fix: updated kubernetes.md" * docs: Update generic.md to include additional info (fossasia#1589) * feat: Replace callbacks with lambdas in adapters (fossasia#1569) * feat: Replace callbacks to lambda in fragments (fossasia#1571) * feat: Add retrolambda and replace callback in activities (fossasia#1568) * feat: Replace callbacks to lambda in DbInstance (fossasia#1570) * docs: Align screenshots in ReadMe (fossasia#1607) * Add branding * Add kubernetes deployment docs. * Fix incorrect syntax and region * fix : App crashing on starting when generated using api endpoint * fix : Remove redundant files from assets * Specify version to kubernetes docs * refactor : Fix codacy issues for generic android app (fossasia#1614) * fix : code style issue * fix : Remove unused fields and imports * fix : Other codacy issues * fix : explicit scop issues * fix : Add comments in default block and rename variable * fix: Change collection lambda and add remaining (fossasia#1623) * fix: NullPointerException in parsing Sessions of Speakers (fossasia#1621) * fix: Shadow between AppBar and TabLayout (fossasia#1599) * fix: Resize splash logo to appropriate size (fossasia#1632) Resize the splash logo shown at app launch to appropriate size maintaining the aspect ratio of the image Fixes fossasia#1591 * Fixes 1419 : Enhance Google PLay map fragment (fossasia#1625) * refactor : Fix codacy issues in app generator v2 (fossasia#1634) * feat: Migrate to Realm (fossasia#1509) * fix: Show disappeared markers in Realm build (fossasia#1638) * Fixes fossasia#1628 : Revert app sharing workflow (fossasia#1635) * refactor: Rewrite ISO8601Date class (fossasia#1617) * feat:Added Track Tags in Schedule(fossasia#1521) (fossasia#1640) * back button in location activity made working (fossasia#1642) * feat: Change edge glow color of RecyclerView of tracks and sessions speaker activity (fossasia#1629) * test: Add date conversion tests (fossasia#1566) * fix: Show speaker image placeholder under no network (fossasia#1647) * fix: Disappearing map icon and map fragment overlay (fossasia#1645) * feat: Show progress bar dialog while downloading event data (fossasia#1630) - Create DownloadCompleteHandler for handling download events - Create fluent API for DownloadCompleteHandler - Remove download related events from MainActivity - Handle events ro show progress of download - Propagate success or error to MainActivity using CompletableSubject - Hide/Show progressbar at appropriate events Fixes fossasia#1490 * fix : App generated using zip is not able to fetch latest data * Move android generator to eventyay-cluster * feat: Ignore build/generated folders while copying in generator (fossasia#1665) * fix: Add JSON payload images in apk - Add speaker and sponsor images in apk - Add option to load images from asset URI via Picasso - Add tests for URI converter * chore: Move Date tests from androidTest/ to test/ (fossasia#1669) * chore: Move Date tests from androidTest/ to test/ * corrected DateTest.java file (fossasia#3) * Update README.md * fix: Remove description and location attributes from Track (fossasia#1674) * fix : Save event date in database when loading from assets (fossasia#1675) * fix: Lenient parsing and error handling throughout the app (fossasia#1663) * fix: Date format and parsing along with unit tests (fossasia#1683) * feat:Added bookmarks in Schedule Page (fossasia#1685) Remove unused imports Fixed Codacy Issues Fixed Codacy Issues Added minor fix * feat: added a video button in SessionDetailActivity.java (fossasia#1686) * feat: New Home Screen with bookmarks and Global Search (fossasia#1565) feat:Global Search Added along with Bookmarks added to Home Page(fossasia#1499) Removed Unused Imports Minor Fixes Restructuring of the ViewHolders done to enable resusability of Code Minor Fixes related to Codacy Improved Search Speed Added improvements from developemt Removed unused imports File formatting done feat: Make color usage and layout normalized Added tags dissappearance * feat : Cache sponsor images and speaker's thumbnails (fossasia#1684) * fix : App crashing when connected to network but internet is not working (fossasia#1513) * fix: Sort sponsors according to level in ascending order (fossasia#1694) * fix: Hide sessions in draft state (fossasia#1692) * fix : App behaviour when api url is not available for event (fossasia#1690) Directly load data from assets without showing dialogue Disable swipe refresh layout * Revert "fix: Sort sponsors according to level in ascending order (fossasia#1694)" This reverts commit 70cae37. * chore: Remove Bookmark Fragment and fragment_bookmarks.xml (fossasia#1698) * fix: Update local json with new date format and add verbose logging * fix: Use common bookmark icon throughout app (fossasia#1696) * fix: maintaining text size throughout the app (fossasia#1707) * fix: maintaining text size throughout the app * fix: maintained uniform text size of elements throughout the app * Improving the map fragment for play version (fossasia#1668) Improving the map fragment for play version Improving the map fragment for play version Improving the map fragment for play version Improving the map fragment for play version Changing the title bar hint color for map * no sessions text handled in location activity (fossasia#1653) * Create CODE_OF_CONDUCT.md * fix: Add new DateUtils fixing local and event dates (fossasia#1700) * feat: added a two pane layout (fossasia#1590) * fix: Show loading progress while parsing local JSON assets (fossasia#1704)
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #1389
Changes: [Add here what changes were made in this issue and if possible provide links.]
Screenshots for the change: