fix: Linking Order Invoice Download to server route #2983

mrsaicharan1 · 2019-05-21T03:56:09Z

Fixes #2925

Short description of what this resolves:

Downloads Order Invoice as PDF(Similar to tickets). Links the button to the server route.

Changes proposed in this pull request:

downloadFile for order invoice downloads
Created an anchor href on-the-fly & supported pdf download
Linked the order generation server route to frontend button
Created separate isLoadingTickets & isLoadingInvoice for loader.

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

abhinavk96

Irrelevant commits are present in the PR
Use es6 getters.

abhinavk96 · 2019-05-22T02:42:59Z

app/controllers/orders/view.js

+          this.get('notify').success(this.get('l10n').t('Here is your Order Invoice'));
+        })
+        .catch(e => {
+          console.warn(e);


don't disable the print thing for now, put it inside the catch block, if for some reason the above fails, it will be a fallback invoice.

mrsaicharan1 · 2019-05-22T06:13:10Z

@CosmicCoder96 @uds5501 @shreyanshdwivedi I've made the necessary changes. Added a GIF in the description for the order invoice downloads.
Also, the isLoading seems to be ambiguous because when one action triggers the isLoading, it shows a change in the other button. I segregated them using isLoadingTickets and isLoadingInvoice.

app/controllers/orders/view.js

Added isLoadingTickets & isLoadingInvoice Changed filename & used ES6 getters Made firefox compatible

auto-label bot added the fix label May 21, 2019

mrsaicharan1 force-pushed the link-invoice branch from 6417429 to aca36c8 Compare May 21, 2019 04:00

abhinavk96 suggested changes May 22, 2019

View reviewed changes

mrsaicharan1 force-pushed the link-invoice branch from aca36c8 to 6e4ec23 Compare May 22, 2019 04:21