Skip to content

Conversation

@kushthedude
Copy link
Member

@kushthedude kushthedude commented Jun 11, 2019

Screenshot :-

image

Short description of what this resolves:

  • Addition of Remaining Stats on Public Event Page

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Jun 11, 2019
@kushthedude
Copy link
Member Author

@uds5501 @shreyanshdwivedi Review !

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushthedude @uds5501 I wanted to ask your opinion if we should implement this toggle feature on tickets or events?
I think it'll be better if we implement it on event rather than ticket because an organizer will not prefer to toggle each ticket.

@uds5501
Copy link
Contributor

uds5501 commented Jun 12, 2019

@shreyanshdwivedi seems fair. what's your opinion on this? @kushthedude

@kushthedude
Copy link
Member Author

@kushthedude @uds5501 I wanted to ask your opinion if we should implement this toggle feature on tickets or events?
I think it'll be better if we implement it on event rather than ticket because an organizer will not prefer to toggle each ticket.

Agreed, @uds5501 I think the following field should be included in Event Schema , I will make appropriate changes

@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 @pradeepgangwar Review Please

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventbrite does not always show how many tickets are available. Probably there is an option for this somewhere in ticket settings in Eventbrite. This feature is low priority and we have very pressing issues to take care of I am closing this therefore. We can come back to topics like these later this year. Thanks.

@kushthedude kushthedude deleted the 3 branch July 13, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Remaining Tickets On Tickets Page if Opted-Out

4 participants