Skip to content

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 11, 2019

Fixes #6031

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Add show_stats_public field for as requested in FE issue

@auto-label auto-label bot added the feature label Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #6032 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6032      +/-   ##
===============================================
+ Coverage        66.26%   66.27%   +<.01%     
===============================================
  Files              285      285              
  Lines            14007    14010       +3     
===============================================
+ Hits              9282     9285       +3     
  Misses            4725     4725
Impacted Files Coverage Δ
app/api/schema/events.py 90% <100%> (+0.06%) ⬆️
app/models/event.py 82.06% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6396cd...2c443e8. Read the comment docs.

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to make, Default Value: False as in fossasia/open-event-frontend#3112

kushthedude
kushthedude previously approved these changes Jun 11, 2019
Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

mrsaicharan1
mrsaicharan1 previously approved these changes Jun 11, 2019
@iamareebjamal
Copy link
Member

Need a better name than this - show_stats_public

@kushthedude
Copy link
Member

@uds5501 Change it to ‘show_remaining_tickets ‘

@shreyanshdwivedi
Copy link
Member

@uds5501 uds5501 force-pushed the showPublicTicket branch from 3b76bb2 to 26d55d9 Compare June 12, 2019 06:44
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 12, 2019

@kushthedude @iamareebjamal @shreyanshdwivedi completed the change

@iamareebjamal iamareebjamal merged commit f192ad5 into fossasia:development Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add show_stats_public field in public tickets page

5 participants