-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add show_stats_public field #6032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## development #6032 +/- ##
===============================================
+ Coverage 66.26% 66.27% +<.01%
===============================================
Files 285 285
Lines 14007 14010 +3
===============================================
+ Hits 9282 9285 +3
Misses 4725 4725
Continue to review full report at Codecov.
|
kushthedude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to make, Default Value: False as in fossasia/open-event-frontend#3112
kushthedude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!
|
Need a better name than this - show_stats_public |
|
@uds5501 Change it to ‘show_remaining_tickets ‘ |
3b76bb2
|
@uds5501 please refer to fossasia/open-event-frontend#3112 (review) |
3b76bb2 to
26d55d9
Compare
|
@kushthedude @iamareebjamal @shreyanshdwivedi completed the change |
Fixes #6031
Checklist
developmentbranch.Short description of what this resolves:
Add show_stats_public field for as requested in FE issue