Tickets not attached when tickets confirmation mail is sent

[abhinavk96]

@mrsaicharan1 The previous refactor for the ticket flow seems to have broken this process. Please consider this a priority issue. The link sent in the mail is broken too. It still points to the old URL.

[mrsaicharan1]

Will get up to speed with this.

[mrsaicharan1]

@CosmicCoder96 I've tested the email and observed that the order invoice link which is being sent points to the proper location.
Also, were the tickets as a pdf attached previously?

def send_email_to_attendees(order, purchaser_id):
    for holder in order.ticket_holders:
        if holder.user and holder.user.id == purchaser_id:
            # Ticket holder is the purchaser
            send_email(
                to=holder.email,
                action=TICKET_PURCHASED,
                subject=MAILS[TICKET_PURCHASED]['subject'].format(
                    event_name=order.event.name,
                    invoice_id=order.invoice_number
                ),
                html=MAILS[TICKET_PURCHASED]['message'].format(
                    pdf_url=holder.pdf_url,
                    event_name=order.event.name
                )
            )
        else:
            # The Ticket holder is not the purchaser
            send_email(
                to=holder.email,
                action=TICKET_PURCHASED_ATTENDEE,
                subject=MAILS[TICKET_PURCHASED_ATTENDEE]['subject'].format(
                    event_name=order.event.name,
                    invoice_id=order.invoice_number
                ),
                html=MAILS[TICKET_PURCHASED_ATTENDEE]['message'].format(
                    pdf_url=holder.pdf_url,
                    event_name=order.event.name
                )
            )

I don't see them being attached anywhere.
If this wasn't there previously, will add the feature to attach invoice+tickets.

[abhinavk96]

@mrsaicharan1 Okay I got confused by the mail body. For TICKET_PURCHASED its:

TICKET_PURCHASED: {
        'recipient': 'User',
        'subject': u'Your order invoice and tickets for {event_name} ({invoice_id}) ',
        'message': (
            u"Hi, this is a confirmation mail of your tickets for the event {event_name}"
            u"<br/>Your order has been processed successfully." +
            u"<br/> <a href='{pdf_url}'>Click here</a> to view/download your invoice."
            u"<br><br><em>Looking forward to seeing you at the event."
            u"<br/>Login to manage your orders at https://eventyay.com </em>"
        )
    },

There is no mention of tickets at all here, just invoice. I assumed they were supposed to be attached. And even though it says invoice it's creating a hyperlink for the tickets for the case where holder is the purchaser. Seems confusing, also either way we need to attach the tickets in the mail. Now that the end point is protected, clicking on the link won't work if the user is not logged in. Although as is the usual scenario user should be able to get the tickets from the mail itself. Can you make it so that the ticket and invoice are attached, and the mail message is non-ambiguous?