-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Attaching tickets+invoice to order emails #5917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb1f182 to
82c3c56
Compare
|
The problem with this approach seems to be that we make ourselves entirely dependent on Sendgrid, which we don't want. We actually want to move away from Sendgrid. We want to be able to send out information no matter what gateway we use. Sendgrid is just one. A better option for now (as we are small) is to use SMTP. |
Codecov Report
@@ Coverage Diff @@
## development #5917 +/- ##
===============================================
- Coverage 66.48% 66.39% -0.09%
===============================================
Files 286 286
Lines 13933 13958 +25
===============================================
+ Hits 9263 9268 +5
- Misses 4670 4690 +20
Continue to review full report at Codecov.
|
|
I’ve chosen this approach because this is being used in production right now. I will implement this for SMTP too. I just did this so that we could have a working system for now. |
0c5de58 to
aa6d6e5
Compare
83ccd4c to
8625b9a
Compare
07bab14 to
3c66317
Compare
abhinavk96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faulty commit history, can't merge
Yeah , was fixing it. Will update. |
3c66317 to
0fd25e1
Compare
0fd25e1 to
60023c7
Compare
|
@CosmicCoder96 @iamareebjamal Fixed conflicts. Please check. |
5f8faf7 to
43240c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrsaicharan1 a codacy issue is left.
43240c0 to
78bb72a
Compare
hound fixes
78bb72a to
9990556
Compare
|
@CosmicCoder96 @iamareebjamal Fixed Codacy & Hound Issues. |
Fixes #5888
Checklist
developmentbranch.Short description of what this resolves:
Order Invoices and Tickets are attached to the emails being sent out when the orders are placed. Currently, we are manually sending an API request to SendGrid which makes it hard to add any new headers, attachments or any new data. The SendGrid Client makes it easier to do this.
Changes proposed in this pull request: