changes for event box component #2710
Conversation
| }, | ||
| locationName: function () { | ||
| return this.event.location_name.split(",")[0]; | ||
| if(this.event.location_name){ |
There was a problem hiding this comment.
I think you should also check for non-empty string. This checks only for the None. Non-empty and undefined should also be checked I think.
There was a problem hiding this comment.
split works well with non-empty string,and since we are retrieving from model and we defined the attribute location_name as a String and initialising it to None , there is no choice for it to be returned as undefined. @SaptakS
| if(this.event.location_name){ | ||
| return this.event.location_name.split(",")[0]; | ||
| } | ||
| else{ |
There was a problem hiding this comment.
Please follow the indentation rule of jslint to put else on the same line as closing bracket of if. Also provide spaces before opening brackets.
| return this.event.location_name.split(",")[0]; | ||
| } | ||
| else{ | ||
| return ""; |
There was a problem hiding this comment.
I don't think returning a blank string necessary either. Please check.
|
@SaptakS made a new commit |
| }, | ||
| locationName: function () { | ||
| return this.event.location_name.split(",")[0]; | ||
| if (this.event.location_name) { |
There was a problem hiding this comment.
Does this check for both null and undefined. Did you try that?
There was a problem hiding this comment.
@nikhilrayaprolu also, we need to return a default value ... Since this is a computed value
| }, | ||
| locationName: function () { | ||
| return this.event.location_name.split(",")[0]; | ||
| if (this.event.location_name) { |
There was a problem hiding this comment.
@nikhilrayaprolu also, we need to return a default value ... Since this is a computed value
Current coverage is 74.82% (diff: 100%)
|
6 participants
In reference to #2692 @niranjan94