-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: Made ticket invoice generation similar to tickets #5886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| else: | ||
| return ForbiddenError({'source': ''}, 'Authentication Required to access ticket').respond() | ||
|
|
||
| @ticket_blueprint.route('/orders/invoices/<string:order_identifier>') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected 2 blank lines, found 1
47dcde8 to
a621c3c
Compare
Codecov Report
@@ Coverage Diff @@
## development #5886 +/- ##
===============================================
- Coverage 66.6% 66.54% -0.07%
===============================================
Files 286 286
Lines 13902 13919 +17
===============================================
+ Hits 9260 9262 +2
- Misses 4642 4657 +15
Continue to review full report at Codecov.
|
|
@uds5501 @shreyanshdwivedi @iamareebjamal Please review |
abhinavk96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give a preview of a sample invoice, also I don't see the billing info in the template.
|
Added serving route and static page Add billing info invoice
|
Thanks a lot! This is a step in the right direction. We need additional information in the invoice.
We also need a way to reflect the different way tax is handled in Europe/Asia and the US:
This is also an option in the tax info. Below is an example of an invoice from eventbrite (for events - we need just the same structure but for tickets) |
|
@mrsaicharan1 feel free to break this up into multiple PRs and issues. Make
this one the parent issue.
…On Thu, 16 May 2019 at 4:52 PM, Mario Behling ***@***.***> wrote:
To make the tax statement clearer I would appreciate if you could make
this slightly different to eventbrite and show the tax in % and in numbers.
Also show the price below the table as follows.
[image: Screenshot from 2019-05-16 10-50-26]
<https://user-images.githubusercontent.com/1583873/57840282-9d6f6a80-77c8-11e9-9a23-8473487ea09c.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5886?email_source=notifications&email_token=AEDUDRN5QVFXRPLJT275YODPVUOC7A5CNFSM4HNCDKCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVREIVY#issuecomment-492979287>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEDUDRJ4KALP5MDOHGUWDALPVUOC7ANCNFSM4HNCDKCA>
.
|
|
@mariobehling @CosmicCoder96 Will make the issue related to this as a parent issue. |
|
-- via Internet Explorer |



Fixes #5878
Checklist
developmentbranch.Short description of what this resolves:
Generates a proper pdf which is served over a route instead of the current snapshot technique for order invoices.
Changes proposed in this pull request: