Skip to content

feat: add role name to json object #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

feat: add role name to json object #6015

merged 1 commit into from
Jun 9, 2019

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 8, 2019 •
edited
Loading

Fixes #6014

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Adds a role-name attribute to the json object. As suggested here fossasia/open-event-frontend#2771

@auto-label auto-label bot added the feature label Jun 8, 2019
@uds5501 uds5501 mentioned this pull request Jun 8, 2019
Merged
5 tasks
prateekj117
prateekj117 reviewed Jun 8, 2019
View reviewed changes
app/api/role_invites.py
"event": role_invite.event_id,
"name": user.fullname if user.fullname else None
"name": user.fullname if user.fullname else None,
"role": uer.role.name
Copy link
Member

@prateekj117 prateekj117 Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo.

Copy link
Contributor Author

@uds5501 uds5501 Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekj117 It's not a typo 😆 , it's a uer object, users_events_roles

Copy link
Member

@kushthedude kushthedude Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501 Can you name more understandable,At first even i thought its a typo

Copy link
Contributor Author

@uds5501 uds5501 Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushthedude I think that wouldn't exactly be necessary. all through our code, uer is being used as users_events_roles model so I think I should stick to it to maintain uniformity.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #6015 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6015   +/-   ##
============================================
  Coverage        66.29%   66.29%           
============================================
  Files              285      285           
  Lines            13997    13997           
============================================
  Hits              9279     9279           
  Misses            4718     4718
Impacted Files Coverage Δ
app/api/role_invites.py 47.95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf70d6...282178f. Read the comment docs.

@uds5501
Copy link
Contributor Author

uds5501 commented Jun 8, 2019

@mrsaicharan1 @shreyanshdwivedi @prateekj117 please review!

@niranjan94 niranjan94 merged commit 66e655c into fossasia:development Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+5 more reviewers

@niranjan94 niranjan94 niranjan94 approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@prateekj117 prateekj117 prateekj117 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add role name in role-invite

7 participants

@uds5501 @niranjan94 @iamareebjamal @mrsaicharan1 @shreyanshdwivedi @prateekj117 @kushthedude