Skip to content

feat: add role name to json object #6015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2019
Merged

feat: add role name to json object #6015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/api/role_invites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ def accept_invite():
return jsonify({
"email": user.email,
"event": role_invite.event_id,
"name": user.fullname if user.fullname else None
"name": user.fullname if user.fullname else None,
"role": uer.role.name
Copy link
Member

@prateekj117 prateekj117 Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo.

Copy link
Contributor Author

@uds5501 uds5501 Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekj117 It's not a typo 😆 , it's a uer object, users_events_roles

Copy link
Member

@kushthedude kushthedude Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501 Can you name more understandable,At first even i thought its a typo

Copy link
Contributor Author

@uds5501 uds5501 Jun 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushthedude I think that wouldn't exactly be necessary. all through our code, uer is being used as users_events_roles model so I think I should stick to it to maintain uniformity.

})


Expand Down