Skip to content

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 9, 2019

Fixes fossasia/open-event-frontend#2169

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

This PR was created because #5657 is becoming increasingly tough to update on my local. So applied the appropriate changes and opening PR.

@auto-label auto-label bot added the fix label Jun 9, 2019
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 9, 2019

@iamareebjamal @shreyanshdwivedi @mrsaicharan1 Please review

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #6017 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6017      +/-   ##
===============================================
+ Coverage        66.29%   66.29%   +<.01%     
===============================================
  Files              285      285              
  Lines            13997    13999       +2     
===============================================
+ Hits              9279     9281       +2     
  Misses            4718     4718
Impacted Files Coverage Δ
app/models/ticket_fee.py 54.83% <100%> (+3.11%) ⬆️
app/api/schema/ticket_fees.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf70d6...38b7a32. Read the comment docs.

@niranjan94 niranjan94 merged commit 40c2400 into fossasia:development Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More than one fee settings can be saved for a payment country - payment currency combination

4 participants