-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: Only admin should be allowed to create event discount codes #6050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only admin should be allowed to create event discount codes #6050
Conversation
|
@uds5501 @mrsaicharan1 @shreyanshdwivedi @iamareebjamal Please review. |
kushthedude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the title of PR to Event Organiser of Event Admin,
Codecov Report
@@ Coverage Diff @@
## development #6050 +/- ##
============================================
Coverage 66.27% 66.27%
============================================
Files 285 285
Lines 14015 14015
============================================
Hits 9288 9288
Misses 4727 4727
Continue to review full report at Codecov.
|
|
@kushthedude , It's actually only admin. @prateekj117 is right 😅 . |
|
Oh my bad @prateekj117 , @uds5501 , I misunderstood it |
|
@prateekj117 @iamareebjamal Should this PR be merged, As Event Discount Code is functional for now? |
|
@CosmicCoder96 Please verify |
shreyanshdwivedi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note : we are not using the event discount code for now, but fixing the code LGTM 👍
Fixes #6049
Checklist
developmentbranch.Short description of what this resolves:
Any user was able to create event discount code.
Changes proposed in this pull request:
-Only admin should be allowed to create an event discount code.