Skip to content

fix: Only admin should be allowed to create event discount codes #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2019
Merged

fix: Only admin should be allowed to create event discount codes #6050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/api/discount_codes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from datetime import datetime

from flask_rest_jsonapi import ResourceDetail, ResourceList, ResourceRelationship
from flask_rest_jsonapi.exceptions import ObjectNotFound
from sqlalchemy.orm.exc import NoResultFound
Expand All @@ -15,7 +17,6 @@
from app.models.ticket import Ticket
from app.models.user import User

from datetime import datetime

class DiscountCodeListPost(ResourceList):
"""
Expand Down Expand Up @@ -48,7 +49,7 @@ def before_post(self, args, kwargs, data):
require_relationship(['event'], data)
if not has_access('is_coorganizer', event_id=data['event']):
raise ForbiddenException({'source': ''}, 'You are not authorized')
elif not data['used_for'] == 'event' and has_access('is_admin') and 'events' in data:
elif data['used_for'] == 'event' and not has_access('is_admin') and 'events' in data:
raise UnprocessableEntity({'source': ''}, "Please verify your permission or check your relationship")

data['user_id'] = current_identity.id
Expand Down