fix: order deletion triggers emails

[uds5501]

Fixes fossasia/open-event-frontend#3269

Short description of what this resolves:

Ensures that deletion of orders doesn't trigger notifications and emails

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[codecov]

Codecov Report

Merging #6184 into development will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           development    #6184   +/-   ##
============================================
  Coverage        66.13%   66.13%           
============================================
  Files              288      288           
  Lines            14479    14479           
============================================
  Hits              9575     9575           
  Misses            4904     4904

Impacted Files	Coverage Δ
app/api/orders.py	31.02% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5f6cd...1551de6. Read the comment docs.

[uds5501]

@mrsaicharan1 @shreyanshdwivedi @prateekj117 Please take a look

[kushthedude]

@uds5501 , There should be an email to attendee perhaps

[uds5501]

@kushthedude deletion of an order doesn't change any status so, IMO there should be none.
Deletion of the order is organizer activity and only unpaid or cancelled tickets can be deleted (AFAIK) so attendee discretion isn't really necessary here.

[kushthedude]

@kushthedude deletion of an order doesn't change any status so, IMO there should be none.
Deletion of the order is organizer activity and only unpaid or cancelled tickets can be deleted (AFAIK) so attendee discretion isn't really necessary here.

Let us take this case, Some user has ordered a bunch of Offline Tickets, Due to some reason Organiser deletes there order, How will the user know his order does not exist now. I totally agree with you that Cancelled or Expired or Pending order should deliver no notification upon deletion .

[uds5501]

@kushthedude as far as notifying them that their order has been deleted, it'll take a new notification and email.
In this particular issue however, what I am trying to point out is that if we allow this behaviour to persist, the user simply gets notified that that their ticket has been placed instead of deleted. Maybe you can open up a new issue for the one you pointed out.