Skip to content

fix: Making Event Name mandatory for publishing of event #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2019
Merged

fix: Making Event Name mandatory for publishing of event #6203

merged 2 commits into from
Jul 16, 2019

Conversation

@kushthedude
Copy link
Member

@kushthedude kushthedude commented Jul 16, 2019

Fixes #6202

@auto-label auto-label bot added the fix label Jul 16, 2019
@kushthedude
Copy link
Member Author

kushthedude commented Jul 16, 2019

@uds5501 @mrsaicharan1 @iamareebjamal Please Review

@codecov
Copy link

codecov bot commented Jul 16, 2019 •
edited
Loading

Codecov Report

Merging #6203 into development will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6203      +/-   ##
===============================================
+ Coverage        65.97%   65.99%   +0.01%     
===============================================
  Files              288      288              
  Lines            14526    14528       +2     
===============================================
+ Hits              9584     9588       +4     
+ Misses            4942     4940       -2
Impacted Files Coverage Δ
app/api/events.py 25.94% <0%> (-0.16%) ⬇️
app/api/helpers/scheduled_jobs.py 24.8% <0%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367836d...61fb1ff. Read the comment docs.

iamareebjamal
iamareebjamal reviewed Jul 16, 2019
View reviewed changes
app/api/events.py
raise ConflictException({'pointer': '/data/attributes/location-name'},
"Online Event does not have any locaton")

if not data.get('name', None) and data.get('state', None) == 'published':
Copy link
Member

@iamareebjamal iamareebjamal Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not data.get('name', None)?

Copy link
Member Author

@kushthedude kushthedude Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because event name should not be empty

@iamareebjamal iamareebjamal merged commit 7b54d2a into fossasia:development Jul 16, 2019
@kushthedude kushthedude deleted the 3 branch July 17, 2019 01:20
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
@kushthedude @iamareebjamal
fix: Making Event Name mandatory for publishing of event (fossasia#6203)
6782502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+2 more reviewers

@uds5501 uds5501 uds5501 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Events without name can be published

4 participants

@kushthedude @iamareebjamal @uds5501 @shreyanshdwivedi